Opened 2 years ago

Closed 2 years ago

#66455 closed enhancement (fixed)

Update x265 port file to add (HDR10+): ENABLE_HDR10_PLUS=ON to the configuration options

Reported by: janngobble Owned by: janngobble
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: x265

Description (last modified by janngobble)

x265 w/o ENABLE_HDR10_PLUS=ON doesn't allow x265/ffmpeg to handle HDR10+ inputs w/o dropping the extra json.

"dhdr_info" is not honored in this situation.

Adding the simple option of ENABLE_HDR10_PLUS=ON to the configuration options allows this.

Basically, this is what needs to be done - and I don't know who did this but It's already here and just needs to be incorporated:

https://p.dnnr.de/ga2IAr7WWE4qiMbS

diff --git a/multimedia/x265/Portfile b/multimedia/x265/Portfile
index 99e435c5635..3a6a94f7c27 100644
--- a/multimedia/x265/Portfile
+++ b/multimedia/x265/Portfile
@@ -55,6 +55,9 @@ platform darwin 10 {
     }
 }
 
+configure.args-append \
+    -DENABLE_HDR10_PLUS=On
+
 if {${universal_possible} && [variant_isset universal] && ![variant_isset highdepth]} {
 
     if {"x86_64" in ${configure.universal_archs} || "i386" in ${configure.universal_archs}} {
@@ -99,15 +102,15 @@ variant highdepth conflicts universal description {Enable 10-bit and 12-bit enco
     configure {
 
         set configure.dir ${workpath}/10bit
-        configure.args -DHIGH_BIT_DEPTH=ON -DEXPORT_C_API=OFF -DENABLE_SHARED=OFF -DENABLE_CLI=OFF
+        configure.args -DENABLE_HDR10_PLUS=ON -DHIGH_BIT_DEPTH=ON -DEXPORT_C_API=OFF -DENABLE_SHARED=OFF -DENABLE_CLI=OFF
         portconfigure::configure_main
 
         set configure.dir ${workpath}/12bit
-        configure.args -DHIGH_BIT_DEPTH=ON -DEXPORT_C_API=OFF -DENABLE_SHARED=OFF -DENABLE_CLI=OFF -DMAIN12=ON
+        configure.args -DENABLE_HDR10_PLUS=ON -DHIGH_BIT_DEPTH=ON -DEXPORT_C_API=OFF -DENABLE_SHARED=OFF -DENABLE_CLI=OFF -DMAIN12=ON
         portconfigure::configure_main
 
         set configure.dir ${workpath}/build
-        configure.args -DEXTRA_LIB="x265_main10.a\;x265_main12.a" -DEXTRA_LINK_FLAGS=-L. -DLINKED_10BIT=ON -DLINKED_12BIT=ON
+        configure.args -DENABLE_HDR10_PLUS=ON -DEXTRA_LIB="x265_main10.a\;x265_main12.a" -DEXTRA_LINK_FLAGS=-L. -DLINKED_10BIT=ON -DLINKED_12BIT=ON
         portconfigure::configure_main
 
     }

Change History (5)

comment:1 Changed 2 years ago by janngobble

Description: modified (diff)

comment:2 Changed 2 years ago by janngobble

Description: modified (diff)
Summary: Update x265 port file to add (HDR10+): ENABLE_HDR10_PLUS=ON to the cmake optionsUpdate x265 port file to add (HDR10+): ENABLE_HDR10_PLUS=ON to the configuration options

comment:3 Changed 2 years ago by eborisch (Eric A. Borisch)

comment:4 Changed 2 years ago by neverpanic (Clemens Lang)

Keywords: hdr10+ HDR10_PLUS removed
Priority: HighNormal

comment:5 Changed 2 years ago by janngobble

Owner: set to janngobble
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.