meson: adding "setup" breaks universal building

[anupamk (Anupam Kapoor)]

Xcode 14.2 (Build version 14C18), macOS Ventura 13.1

Installing x2goclient @4.1.2.2_2 I see the following

Error: Failed to configure orc: configure failure: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port x2goclient failed

here are last couple of lines from the log file:

:info:configure Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/orc-0.4.33-x86_64" && /opt/local/bin/meson setup --prefix=/opt/local --host=x86_64-apple-darwin22 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/orc-0.4.33-x86_64 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/build-x86_64 --cross-file=x86_64-darwin
:debug:configure system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/orc-0.4.33-x86_64" && /opt/local/bin/meson setup --prefix=/opt/local --host=x86_64-apple-darwin22 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/orc-0.4.33-x86_64 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/build-x86_64 --cross-file=x86_64-darwin
:info:configure usage: meson [-h] {setup,configure,dist,install,introspect,init,test,wrap,subprojects,rewrite,compile,devenv,env2mfile,help} ...
:info:configure meson: error: unrecognized arguments: --host=x86_64-apple-darwin22
:info:configure Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/orc-0.4.33-x86_64" && /opt/local/bin/meson setup --prefix=/opt/local --host=x86_64-apple-darwin22 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/orc-0.4.33-x86_64 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_orc/orc/work/build-x86_64 --cross-file=x86_64-darwin
:info:configure Exit code: 2

please do let me know if you may require more information about this, and I will be more than happy to provide the details that you may need.

--

thank you

best regards

[jmroot (Joshua Root)]

Please attach the log file.

[leebaylis]

I'm having the same problem on XCode 14.2, MacOs Monterey 12.6.2 on an M1 macbook air, also with orc @0.4.33 +universal as a dependency trying to install x2goclient.

I attached my log file. Thanks!

[anupamk (Anupam Kapoor)]

configure logs

[anupamk (Anupam Kapoor)]

i have just added the logs for the issue.

--

thank you

best regards

[kencu (Ken)]

have to strip the -host argument off for meson to accept the command line.

muniversal 1.0 adds it automatically unless you tell it not to.

[kencu (Ken)]

Now that the meson PortGroup adds "setup" onto the configure command, universal building is broken because the configure.cmd no longer ends in "meson"

​https://github.com/macports/macports-ports/commit/3b55cb976ef7916d123b0c0c7f8cfe082bf3eb0a

move "setup" to the post-args instead

[kencu (Ken)]

In 1624a1e5e2b54de8045d73a381b70dfe63b1e4da/macports-ports (master):

Revert "meson-1.0: Always run meson setup"

This reverts commit 3b55cb976ef7916d123b0c0c7f8cfe082bf3eb0a.

This commit breaks all universal building using meson.
Revert until a new plan is in place.

closes: #66761

[kencu (Ken)]

Dean, can you help us come up with a new option here?

Either the muniversal portgroups need to be changed to do the right thing with the configure command ending with “meson setup” or the "setup" command needs to be added to the "configure.pre_args" -- prepended to it I guess. That might be the best, as the configure command is really not supposed to have any arguments added on to it for just this reason...

Or some similarly suitable option that keeps universal building working.

Thanks!

[Gcenx]

Replying to kencu:

Dean, can you help us come up with a new option here?

Either the muniversal portgroups need to be changed to do the right thing with the configure command ending with “meson setup” or the "setup" command needs to be added to the "configure.pre_args" -- prepended to it I guess. That might be the best, as the configure command is really not supposed to have any arguments added on to it for just this reason...

Or some similarly suitable option that keeps universal building working.

Thanks!

Decided to add it via configure.pre_args that indeed seems the safest and cleanest option.

​https://github.com/macports/macports-ports/pull/17482

[Dean M Greer <38226388+Gcenx@…>]

In 67f07861653d2430942a447148a8dfd4dbca14f6/macports-ports (master):

meson-1.0: Add setup using configure.pre_args (​https://github.com/macports/macports-ports/pull/17482)

meson now requires "${prefix}/bin/meson setup" when configuring, not just ${prefix}/bin/meson"

However, tacking "setup" onto the configure.cmd interferes with the way the muniversal portgroups decide what kind of build is being done.

So we will try adding "setup" via configure.pre_args instead, to avoid this.

see: #66761