libnetpbm: Failed to extract libnetpbm: extract.rename: multiple directories exist in /opt/local/var/macports/build/_opt_mports_macports-ports_graphics_netpbm/libnetpbm/work

[mf2k (Frank Schima)]

Running latest base from HEAD. It appears that the fix for issues like #66415 does not work for multiple distfiles.

:error:extract Failed to extract libnetpbm: extract.rename: multiple directories exist in /opt/local/var/macports/build/_opt_mports_macports-ports_graphics_netpbm/libnetpbm/work: 
/opt/local/var/macports/build/_opt_mports_macports-ports_graphics_netpbm/libnetpbm/work/netpbm-mirror-62c62a8423c7d6746f437f46c35499281c39e4dd
/opt/local/var/macports/build/_opt_mports_macports-ports_graphics_netpbm/libnetpbm/work/netpbm-mirror-a70405848cb06782036364a88e27f452fb0a0b32

[jmroot (Joshua Root)]

There's never been automatic handling of multiple directories. I would guess this must have its own renaming in place and so can change extract.rename to no.

[ryandesign (Ryan Carsten Schmidt)]

I'm frustrated that base has been changed in such a way that breaks ports again.

This port renames the extracted directories as needed in the post-extract phase. This worked fine before. Why is base now making this more difficult?

[mf2k (Frank Schima)]

Replying to jmroot:

There's never been automatic handling of multiple directories. I would guess this must have its own renaming in place and so can change extract.rename to no.

Confirmed that it works for me.

[jmroot (Joshua Root)]

Replying to ryandesign:

This port renames the extracted directories as needed in the post-extract phase. This worked fine before. Why is base now making this more difficult?

Base isn't setting this option, the github portgroup is. Most ports using that portgroup need the option to avoid setting worksrcdir manually. If you know a way to automatically exclude ports like this that do their own renaming, please implement it.

If you're asking why an option like extract.rename is necessary, the previous behaviour also breaks ports, it just does so silently. Now you get an error if it doesn't work.

[jmroot (Joshua Root)]

In 07931f78b1c476d3f7c5d9ed7baa8b895c12f81b/macports-ports (master):

netpbm: fix extract failure

Closes: #66779

[ryandesign (Ryan Carsten Schmidt)]

If setting extract.rename yes does not work with multiple directories, then why does the github portgroup set extract.rename yes when there are multiple directories?

[jmroot (Joshua Root)]

The portgroup currently has no knowledge of how many directories there are. If you know how to make it figure that out and take it into account, that would be a great improvement to make.