#67031 closed defect (invalid)

xar: patch does not apply on Macports 2.8.0 (can be closed, works with 2.8.1)

Reported by: barracuda156 Owned by: Schamschula (Marius Schamschula)
Priority: Normal Milestone:
Component: ports Version: 2.8.0
Keywords: Cc:
Port: xar

Description

--->  Extracting xar-494.81.1.tar.gz
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_xar/xar/work" && /usr/bin/gzip -dc '/opt/local/var/macports/distfiles/xar/xar-494.81.1.tar.gz' | /usr/bin/gnutar --no-same-owner -xf - 
--->  Applying patches to xar
--->  Applying xar-1.8-Add-OpenSSL-To-Configuration.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_xar/xar/work/xar-494.81.1/xar" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/archivers/xar/files/xar-1.8-Add-OpenSSL-To-Configuration.patch'
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -rupN a/configure.ac b/configure.ac
|--- configure.ac	2020-01-25 04:24:35.603846773 +0300
|+++ configure.ac	2020-01-25 04:41:05.743109638 +0300
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
1 out of 1 hunk ignored
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_xar/xar/work/xar-494.81.1/xar" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/archivers/xar/files/xar-1.8-Add-OpenSSL-To-Configuration.patch'
Exit code: 1
Error: Failed to patch xar: command execution failed

Attachments (2)

xar.txt (14.5 KB) - added by barracuda156 20 months ago.
10.8.6/x86_64 +universal
xar_again.txt (7.4 KB) - added by barracuda156 20 months ago.
Another machine with 10.6.8 x86_64, same failure

Download all attachments as: .zip

Change History (11)

comment:1 Changed 21 months ago by jmroot (Joshua Root)

Owner: set to Schamschula
Status: newassigned

comment:2 Changed 21 months ago by ryandesign (Ryan Carsten Schmidt)

I can't reproduce that on Monterey x86_64.

Last edited 21 months ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:3 Changed 21 months ago by Schamschula (Marius Schamschula)

I don't know what happened in your case, but I have the current version of xar installed on all my machines (Big Sur through Ventura). A full main.log would help, or at least your OS version and hardware platform.

Changed 20 months ago by barracuda156

Attachment: xar.txt added

10.8.6/x86_64 +universal

comment:4 Changed 20 months ago by Schamschula (Marius Schamschula)

1) Looking at your main.log, It appears that you have tried to build xar twice without first doing port clean.

2) I cannot reproduce this issue. All patches apply, some with offset chunks.

comment:5 in reply to:  4 Changed 20 months ago by barracuda156

Replying to Schamschula:

1) Looking at your main.log, It appears that you have tried to build xar twice without first doing port clean.

2) I cannot reproduce this issue. All patches apply, some with offset chunks.

It reproducibly fails for me. Just tried on another machine, 10.6.8 x86_64, same story.

Changed 20 months ago by barracuda156

Attachment: xar_again.txt added

Another machine with 10.6.8 x86_64, same failure

comment:6 Changed 20 months ago by barracuda156

Just noticed that both machines use Macports 2.8.0. Could it be the reason? Let me try updating.

UPD. Can be closed, it works fine with 2.8.1. That 2.8.0 release was really off.

Last edited 20 months ago by barracuda156 (previous) (diff)

comment:7 Changed 20 months ago by barracuda156

Version: 2.8.12.8.0

comment:8 Changed 20 months ago by barracuda156

Summary: xar: patch does not applyxar: patch does not apply on Macports 2.8.0 (can be closed, works with 2.8.1)

comment:9 in reply to:  6 Changed 20 months ago by ryandesign (Ryan Carsten Schmidt)

Resolution: invalid
Status: assignedclosed

Replying to barracuda156:

That 2.8.0 release was really off.

The 2.8.0 release wasn't "off".

MacPorts 2.8.1 reverted a change that had been made back in MacPorts 2.6.0 that provided some automatic handling for ports that do not specify the correct worksrcdir and new code handling that situation in a different way was added. The github portgroup has always (since long before MacPorts 2.6.0) included its own code to handle that situation, since ports like xar that use automatically-generated github tarballs do not specify the correct worksrcdir because it is inconvenient to do so because it changes with every version. The github portgroup was modified on January 6 to use the new MacPorts base code when MacPorts 2.8.1 or later is used.

We don't support the use of older MacPorts versions once a new one has been available for 2 weeks. MacPorts 2.8.1 was out on January 30. The old code in the github portgroup that allowed it to work on MacPorts 2.8.0 and earlier was removed on February 25 which could explain your difficulty trying to install an affected port with MacPorts 2.8.0 on March 3.

Note: See TracTickets for help on using tickets.