#672 closed defect (fixed)
curl program does not properly fail on bad download
Reported by: | robert@… | Owned by: | fkr@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | base | Version: | 1.0 |
Keywords: | Cc: | ||
Port: |
Description
When issuing a "port fetch" on a port, if the download fails due to a missing file, or other HTTP error, the options currently defined in the "portfetch.tcl" file will not properly fail the "port fetch" command and it will think it downloaded the file, when in reality it only downloaded an HTTP error page instead. The port will not build from this point because the checksum will fail, but the fetch will not be re-run because it thinks the file was successfully downloaded and will be skipped.
The attached patch adds the appropriate options to the "curl" command args to properly fail on bad or incomplete downloads so the "port" code can properly detect a download failure.
Please apply this fix to the CVS repository.
Thanks!
Attachments (1)
Change History (6)
Changed 21 years ago by robert@…
Attachment: | portfetch.patch added |
---|
comment:1 Changed 21 years ago by robert@…
This fix appears to have been committed (at least the critical "-f" option part).
Should the "-L' be added as a default as well????
comment:2 Changed 21 years ago by wbb4@…
Owner: | changed from darwinports-bugs@… to wbb4@… |
---|
comment:3 Changed 21 years ago by wbb4@…
Owner: | changed from wbb4@… to darwinports-bugs@… |
---|
comment:4 Changed 21 years ago by fkr@…
Owner: | changed from darwinports-bugs@… to fkr@… |
---|
this will be included in my patch to to portfetch.tcl. thanks! -fkr
fixed curl download failure detection problem