libupnp: uses gtest opportunistically

[barracuda156]

-- Found Threads: TRUE  
-- Check size of pthread_rwlock_t
-- Check size of pthread_rwlock_t - done
CMake Error at CMakeLists.txt:315 (add_subdirectory):
  add_subdirectory given source "gtest" which is not an existing directory.


-- Configuring incomplete, errors occurred!

[ctreleaven (Craig Treleaven)]

Could you please attach the complete build log.

[ryandesign (Ryan Carsten Schmidt)]

And show us the directory listing of the source directory inside the work directory.

[ryandesign (Ryan Carsten Schmidt)]

Oh. I thought the problem was that the gtest directory was supposed to be there and didn't get extracted on your system for some reason. But I see now that the gtest directory, although it is in the repository, is not in the tarball. And the CMakeLists.txt tries to use the nonexistent gtest directory if it detects that the gtest program is installed. I ​reported the bug to the developers. You can work around the problem using trace mode (sudo port -t install libupnp) or just deactivate or uninstall gtest first. Craig, you should make sure that the libupnp port does not try to use gtest even if it is installed (or add the gtest dependency once the gtest directory is in the tarball).

[ryandesign (Ryan Carsten Schmidt)]

The developer released 1.14.17 to fix the missing gtest directory issue and we should update to it (#67337) but the port still needs to be modified to prevent the opportunistic use of gtest.

[ctreleaven (Craig Treleaven)]

In 17385589df6f8290a8bc2fdb8e6318009a3a5c78/macports-ports (master):

libupnp: update to 1.14.17, etc

-correct license
-improve handling of tests

fixes: #67333