Opened 18 months ago
Last modified 15 months ago
#67408 assigned defect
gimp2,gtk3: submit latest patches to upstream
| Reported by: | mascguy (Christopher Nielsen) | Owned by: | mascguy (Christopher Nielsen) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.8.1 |
| Keywords: | pending | Cc: | lukaso (Lukas Oberhuber), rmottola (Riccardo), cooljeanius (Eric Gallager) |
| Port: | gtk3 gimp2 |
Description (last modified by mascguy (Christopher Nielsen))
For their latest releases, several patches have been applied to gtk3 and gimp2. Submit PRs/MRs to upstream, in hopes of having the changes merged.
Patches for gtk3:
patch-quartz-meson-appleframeworks.diff: patchgdk/quartz/meson.build, to make frameworkCoreGraphicsoptional; not available for 10.7 and earlier.
patch-quartz-nseventtype.diff: patchgdk/quartz/gdkdisplaylinksource.c, to replace hard-coded use ofNSEventTypeApplicationDefined, withGDK_QUARTZ_APPLICATION_DEFINED.
Patches for gimp2:
patch-updatecheck-nsurlsession.diff: disable use ofNSURLSessionfor macOS 10.8 and earlier; only available in 10.9 and later.
Attachments (4)
Change History (17)
comment:1 Changed 18 months ago by mascguy (Christopher Nielsen)
| Cc: | lukaso added |
|---|
comment:2 Changed 18 months ago by mascguy (Christopher Nielsen)
| Description: | modified (diff) |
|---|
comment:3 Changed 18 months ago by mascguy (Christopher Nielsen)
| Description: | modified (diff) |
|---|
comment:4 Changed 18 months ago by mascguy (Christopher Nielsen)
comment:5 Changed 18 months ago by mascguy (Christopher Nielsen)
gtk3 patch patch-quartz-meson-appleframeworks.diff submitted to upstream:
5959 - macOS 10.7 Quartz patch: gdk/quartz/meson.build: make dependency CoreGraphics optional
comment:6 Changed 18 months ago by mascguy (Christopher Nielsen)
gimp2 patch patch-updatecheck-nsurlsession.diff submitted to upstream:
comment:7 Changed 18 months ago by Christopher Nielsen <mascguy@…>
comment:8 Changed 18 months ago by Christopher Nielsen <mascguy@…>
comment:9 Changed 18 months ago by mascguy (Christopher Nielsen)
Observers: While all of the patches have been submitted, let's keep this open until all have been accepted.
comment:10 Changed 18 months ago by mascguy (Christopher Nielsen)
| Cc: | rmottola added |
|---|
comment:11 Changed 18 months ago by Christopher Nielsen <mascguy@…>
comment:12 Changed 17 months ago by cooljeanius (Eric Gallager)
| Cc: | cooljeanius added |
|---|
Changed 15 months ago by rmottola (Riccardo)
| Attachment: | gtk3_gdkquartznswindows_c.patch added |
|---|
some 10.5/10.6 replacement methods
Changed 15 months ago by rmottola (Riccardo)
| Attachment: | gtk3_gdkquartzview_c.diff added |
|---|
other minor 10.5/10.6 replacement
comment:13 Changed 15 months ago by rmottola (Riccardo)
in updateLayer, I get an issue casting from and to CGRect and NSRect... I didn't get it. The method convertRectToBacking I supply is correctly taking and giving NSRect.
Is the compiler more sensitive?
I tried this now:
CGRect backing_bounds = NSRectToCGRect([self convertRectToBacking: NSRectFromCGRect(layer_bounds)]);
Changed 15 months ago by rmottola (Riccardo)
| Attachment: | gtk3_gdk_gdkglcontext-quartz_c.diff added |
|---|
ignore 10.7+ format attribute if not supported
Changed 15 months ago by rmottola (Riccardo)
| Attachment: | gtk3_gdkwindow_quartz_c.diff added |
|---|
futher replacements for 10.5/10.6
gtk3patchpatch-quartz-nseventtype.diffsubmitted to upstream:5958 - macOS 10.11 Quartz patch: gdkdisplaylinksource: use GDK_QUARTZ_APPLICATION_DEFINED, rather than NSEventTypeApplicationDefined