qt5-qtlocation @5.15.8_1 build failure

[dbl001 (dbl)]

:info:build include/mbgl/util/unique_any.hpp:51:31: error: no member named 'move' in namespace 'std'
:info:build             vtable->move(std::move(rhs.storage), storage);
:info:build                          ~~~~~^
:info:build include/mbgl/util/unique_any.hpp:69:25: error: no member named 'move' in namespace 'std'
:info:build         unique_any(std::move(rhs)).swap(*this);
:info:build                    ~~~~~^
:info:build include/mbgl/util/unique_any.hpp:91:33: error: no type named 'move' in namespace 'std' 
:info:build             unique_any tmp(std::move(rhs));
:info:build                            ~~~~~^
:info:build include/mbgl/util/unique_any.hpp:94:39: error: no member named 'move' in namespace 'std'
:info:build                 rhs.vtable->move(std::move(storage), rhs.storage);
:info:build                                  ~~~~~^
:info:build include/mbgl/util/unique_any.hpp:98:35: error: no member named 'move' in namespace 'std'
:info:build                 vtable->move(std::move(tmp.storage), storage);
:info:build                              ~~~~~^
:info:build include/mbgl/util/unique_any.hpp:154:41: error: no member named 'move' in namespace 'std'; did you mean simply 'move'?
@                                                                               

[mascguy (Christopher Nielsen)]

It looks (?) like the appropriate Cxx standard is being specified during compilation, so it's possible that upstream is simply missing #include <utility> somewhere.

[mascguy (Christopher Nielsen)]

Based on a quick review of upstream's code, it looks like #include <utility> is only missing from include/mbgl/util/unique_any.hpp.

[mascguy (Christopher Nielsen)]

PR created:

​18656 - qt5-qtlocation: mapbox-gl-native: patch unique_any.hpp, for std::move

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

#include <typeinfo>
#include <type_traits>
#include <stdexcept>

int main() {
    int x = 5;
    int y = std::move(x);
}

env SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk clang++ main.cxx compiles fine.
env SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk clang++ main.cxx give the error reported here.

Looking through some of the system header files, it seems that Xcode has been removing #include <utility> from header files.

[Christopher Nielsen <mascguy@…>]

In 9f6653ca55c4d87b7a5a26368dbddc6192a4f86a/macports-ports (master):

qt5-qtlocation: mapbox-gl-native: patch unique_any.hpp, for std::move

• Include for <utility> missing from: mbgl/util/unique_any.hpp

Fixes: #67417

[barracuda156]

Replying to mascguy:

Not directly related to this issue, but maybe you know a fix for #68508 – otherwise depends do not build on Sonoma.

[chrstphrchvz (Christopher Chavez)]

The same fix is still needed for qt59-qtlocation, qt511-qtlocation, and qt513-qtlocation: ​https://github.com/macports/macports-ports/pull/21982

[chrstphrchvz (Christopher Chavez)]

In 0027bd56ac4a68df4309f77a270fdc86c0028602/macports-ports (master):

qt(59|511|513)-qtlocation: add missing header include

See: #67417