Opened 18 months ago
Closed 17 months ago
#67614 closed update (fixed)
OpenSMTPD 7.3.0p0 rc2 preliminary Portfile
Reported by: | artkiver (グレェ) | Owned by: | ryanakca (Ryan Kavanagh) |
---|---|---|---|
Priority: | Low | Milestone: | |
Component: | ports | Version: | 2.8.1 |
Keywords: | Cc: | ||
Port: | OpenSMTPD |
Description
Omar Polo recently requested testing for OpenSMTPD 7.3.0p0 here:
https://www.mail-archive.com/misc@opensmtpd.org/msg05844.html
On June 3rd also iterated RC2 here:
https://bsd.network/@op/110479505851501072
Since OpenSMTPD hasn't seen an official release update in years, I thought I would give a go at revising the Portfile a bit.
However, I am not presently in a situation where I have any system which can do much actual testing of an SMTP daemon.
Primary changes:
Remove OpenSSL Portgroup and use the dylib (so this will build against LibreSSL if installed). change checksums (obviously) I am using the github Portgroup for this, because it is pre-release, those changes are probably not worth retaining when this is no longer a Release Candidate, but for testing this is OK.
I removed the autoreconf and bootstrap lines, because bootstrap was not found with this version, and it was breaking the build until those lines were removed.
Anyway, not trying to create more work for you Ryan, hopefully just providing something for review and testing, this will doubtlessly need to be modified for the actual release.
Attachments (2)
Change History (9)
Changed 18 months ago by artkiver (グレェ)
Attachment: | Portfile.opensmtpd7.3.0p1rc2 added |
---|
comment:1 Changed 18 months ago by artkiver (グレェ)
I should probably note: at least locally on my test system I have libressl-devel (https://ports.macports.org/port/libressl-devel/) installed which is presently LibreSSL 3.8.0 so the notes in op's post about
$ ./configure --with-bundled-libtls
Can be ignored.
That probably isn't true for those who are using OpenSSL(3); less sure for those using libressl (3.7.3 currently in MacPorts) as I haven't tested that yet either.
comment:2 Changed 18 months ago by ryandesign (Ryan Carsten Schmidt)
Milestone: | MacPorts Future |
---|---|
Port: | OpenSMTPD added |
The Milestone field is only used when the Component field is "base".
Don't set github.tarball_from archive
and then override master_sites
with the release download URL; instead, set github.tarball_from releases
.
Consider switching to the legacysupport 1.1 portgroup and removing the platforms darwin
line.
comment:3 follow-up: 4 Changed 18 months ago by ryandesign (Ryan Carsten Schmidt)
Please attach your proposed changes as a diff against the Portfile currently in the tree, not as a complete new Portfile, so that it's easier to see and evaluate the changes.
Changed 18 months ago by artkiver (グレェ)
Attachment: | Portfile.diff.opensmtpd7.3.0p1rc2 added |
---|
diff for OpenSMTP 7.3.0p1 RC 2 relative to the Portfile currently in the tree with suggestions for improvement from ryandesign in comment 2.
comment:4 Changed 18 months ago by artkiver (グレェ)
Thanks for the review and suggestions for improvement! I've attached a diff which reflects the improvements you made.
Replying to ryandesign:
Please attach your proposed changes as a diff against the Portfile currently in the tree, not as a complete new Portfile, so that it's easier to see and evaluate the changes.
comment:5 Changed 17 months ago by artkiver (グレェ)
7.3.0p0 was officially released on 2023-06-17 (June 17th, 2023).
Using this previous effort as a basis, I spruced up the Portfile (omitting the GitHub related PortGroup changes as an official tarball is now available on opensmtpd.org) and submitted a PR here:
comment:6 Changed 17 months ago by artkiver (グレェ)
Some additional notes: I did test building this both against libressl-devel (presently at 3.8.0) and openssl3 (presently at 3.1.1) and it seemed as if there were no issues there, so hopefully moving away from PortGroup openssl 1.0 and instead utilizing path:lib/libssl.dylib:openssl as a depends_lib is sufficient for supporting multiple TLS libraries available in MacPorts?
However, I am not presently in an environment where I can test an MX so my PR submission is more in relation to me having tested the build on the updated code, not testing functionality for real world usage.
comment:7 Changed 17 months ago by artkiver (グレェ)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Portfile for OpenSMTPD 7.3.0p1 RC2, just for testing for now.