#67785 closed defect (fixed)

sbcl @2.3.6: patch failure on Big Sur

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: easye
Priority: Normal Milestone:
Component: ports Version: 2.8.1
Keywords: bigsur Cc: catap (Kirill A. Korinsky)
Port: sbcl

Description

sbcl fails to patch on Big Sur only:

https://build.macports.org/builders/ports-11_arm64-builder/builds/96914/steps/install-port/logs/stdio

Executing:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_sbcl/sbcl/work/sbcl-2.3.6" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/sbcl/files/0004-arm-Darwin-disable-futex-on-BigSur.patch'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_sbcl/sbcl/work/sbcl-2.3.6" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/sbcl/files/0004-arm-Darwin-disable-futex-on-BigSur.patch'
patching file make-config.sh
patching file src/cold/shared.lisp
Hunk #1 FAILED at 291.
1 out of 1 hunk FAILED -- saving rejects to file src/cold/shared.lisp.rej

Whatever bug this patch is fixing really only occurs on Big Sur? Not on earlier nor later versions of macOS? Is there an upstream bug URL for this problem?

Change History (4)

comment:1 Changed 16 months ago by tomio-arisaka (Tomio Arisaka)

comment:2 Changed 16 months ago by catap (Kirill A. Korinsky)

This is forgotten to be removed patch from the last update. I'll make a PR in couple of hours.

comment:3 Changed 16 months ago by catap (Kirill A. Korinsky)

Ryan, the issue that futex aren't work as expected on BigSur and SBCL enforced it on any macOS on ARM. The old patch was required for 2.3.5 where it was introduced. Anyway, since 2.3.6 it doesn't an issue and upstream fixed it the right way.

See: https://github.com/macports/macports-ports/pull/19540

comment:4 Changed 16 months ago by catap (Kirill A. Korinsky)

Resolution: fixed
Status: assignedclosed

In 2823cd3bd26eb2c3c37cf248e0210bb3714ae135/macports-ports (master):

sbcl: removed unrequired patch for BigSur

This patch hasn't required for 2.3.6 anymore.

Closes: #67785

Note: See TracTickets for help on using tickets.