Context Navigation

← Previous Ticket
Next Ticket →

#67874 assigned update

mosquitto: update to 2.0.16

Reported by:	danh1979	Owned by:	slewsys (Andrew L. Moore)
Priority:	Normal	Milestone:
Component:	ports	Version:	2.8.1
Keywords:	haspatch	Cc:	slewsys (Andrew L. Moore)
Port:	mosquitto

Description (last modified by danh1979)

This was tested on Ventura 13.5 on M2 Pro by creating my own local Portfile and installing it from source. After some Internet-search-aided debugging, I found that I needed to:

add libcjson dependency
deal with missing symbols via the extra linker flag
deal with an xslt error by installing docbook XSL

Code highlighting:

net/mosquitto/Portfile

diff --git a/net/mosquitto/Portfile b/net/mosquitto/Portfile
index 61e7927e..750e462f 100644

  PortSystem          1.0
 PortGroup           cmake 1.1
 name                mosquitto
 version             2.0.9
 revision            1
+version             2.0.16
+revision            0
 categories          net devel
 platforms           darwin
-…
+ long_description    \
     both  C and C++ client libraries.
 homepage            https://mosquitto.org
 master_sites        http://mosquitto.org/files/source/
+master_sites        ${homepage}/files/source/
 checksums           rmd160  6925455f51b6c79ebd160aba2f3709864aa5c05d \
                     sha256  1b8553ef64a1cf5e4f4cfbe098330ae612adccd3d37f35b2db6f6fab501b01d4 \
                     size    757878
+checksums           rmd160  1f0e5e1a1e700a06af52509fd132702ef7d04a1c \
+                    sha256  638db9e43e89d243ea98d10d66e76ff376131217780decd01abaffacc66d8035 \
+                    size    795906
 depends_build-append \
+                    path:bin/xsltproc:libxslt
+                    path:bin/xsltproc:libxslt \
+                    port:docbook-xsl-nons
 depends_lib         port:c-ares \
+                    port:libcjson \
                     port:libwebsockets \
                     port:tcp_wrappers \
                     path:lib/libssl.dylib:openssl
-…
+ depends_lib         port:c-ares \
 depends_test-append \
                     port:python27
+patchfiles CMAKE_MODULE_LINKER_FLAGS.patch
 configure.args-append \
                     -DUSE_LIBWRAP:BOOL=ON \
                     -DWITH_SRV:BOOL=ON \

new file net/mosquitto/files/CMAKE_MODULE_LINKER_FLAGS.patch

diff --git a/net/mosquitto/files/CMAKE_MODULE_LINKER_FLAGS.patch b/net/mosquitto/files/CMAKE_MODULE_LINKER_FLAGS.patch
new file mode 100644
index 00000000..ec3044ea

-                      -
+--- CMakeLists.txt.orig 2023-08-03 23:00:17
++++ CMakeLists.txt      2023-08-03 23:00:13
+@@ -20,7 +20,7 @@
+ endif (WIN32)
+ if(APPLE)
+-       set(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "${CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS} -undefined dynamic_lookup")
++       set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -undefined dynamic_lookup")
+ endif(APPLE)
+ include(GNUInstallDirs)

Attachments (2)

macports-ports.mosquitto-2.0.15.patch (2.3 KB) - added by danh1979 15 months ago.: macports-ports.mosquitto-2.0.15.patch
macports-ports.mosquitto-2.0.16.patch (2.3 KB) - added by danh1979 15 months ago.: mosquitto: update to 2.0.16

Download all attachments as: .zip

Change History (8)

comment:1 Changed 16 months ago by ryandesign (Ryan Carsten Schmidt)

Owner:	set to slewsys
Status:	new → assigned

revision should drop to 0 when the version is increased.

http://mosquitto.org redirects to https://mosquitto.org so master_sites should be changed to ${homepage}/files/source/.

Needing to specify -undefined dynamic_lookup manually is surprising and suggests a bug in the build system. What error did you get before adding that? Did you file a bug report with upstream? Please provide its URL.

comment:2 Changed 15 months ago by ryandesign (Ryan Carsten Schmidt)

Summary:	update mosquitto to 2.0.15 → mosquitto: update to 2.0.15

comment:3 Changed 15 months ago by danh1979

Description:	modified (diff)

I updated the patch with the revision and master_sites suggestions.

Regarding -undefined dynamic_lookup, it seems there are some plugins in mosquitto, written add_library(targetname MODULE ...) in cmake, where targetname is one of these three:

mosquitto_dynamic_security
mosquitto_message_timestamp
mosquitto_payload_modification

These don't compile without adding -DCMAKE_MODULE_LINKER_FLAGS="-undefined dynamic_lookup".

Prompted by your suggestion, and then learning about cmake-1.1.tcl and recreating a macports-equivalent build environment, I searched the mosquitto source and found

https://github.com/eclipse/mosquitto/blob/v2.0.15/CMakeLists.txt#L22

If I change this to

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b8913c2d..145f6255 100644

  if (WIN32)
 endif (WIN32)
 if(APPLE)
        set(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "${CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS} -undefined dynamic_lookup")
+       set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -undefined dynamic_lookup")
 endif(APPLE)
 include(GNUInstallDirs)

... then mosquitto builds without -DCMAKE_MODULE_LINKER_FLAGS="-undefined dynamic_lookup" fed on the cmake command line.

comment:4 Changed 15 months ago by danh1979

Description:	modified (diff)

modified patch for this port to use a patch for mosquitto's CMakeLists.txt instead of an extra command line arg

comment:5 Changed 15 months ago by danh1979

Looks like mosquitto already has an issue; I added a comment https://github.com/eclipse/mosquitto/issues/2858

Changed 15 months ago by danh1979

Attachment:	macports-ports.mosquitto-2.0.15.patch added

macports-ports.mosquitto-2.0.15.patch

Changed 15 months ago by danh1979

Attachment:	macports-ports.mosquitto-2.0.16.patch added

mosquitto: update to 2.0.16

comment:6 Changed 15 months ago by danh1979

Description:	modified (diff)
Summary:	mosquitto: update to 2.0.15 → mosquitto: update to 2.0.16

Note: See TracTickets for help on using tickets.

Download in other formats: