rpki-client @8.5: error: implicit declaration of function 'mkostemp' is invalid in C99

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/230175/steps/install-port/logs/stdio

  CC       rpki_client-output.o
  CC       rpki_client-parser.o
  CC       rpki_client-print.o
  CC       rpki_client-repo.o
output.c:137:7: error: implicit declaration of function 'mkostemp' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        fd = mkostemp(output_tmpname, O_CLOEXEC);
             ^
output.c:137:7: note: did you mean 'mkstemp'?
/usr/include/stdlib.h:201:6: note: 'mkstemp' declared here
int      mkstemp(char *);
         ^
1 error generated.
make[1]: *** [rpki_client-output.o] Error 1
make[1]: *** Waiting for unfinished jobs....

And please disable silent rules.

[artkiver (グレェ)]

Thanks for that! I brought this to the attention of one of the rpki-client developers, Job Snijders who in turn seemed to think it looked like this issue:

​https://github.com/att/ast/issues/976

Given the apparent fix there (e.g. ​https://github.com/att/ast/commit/f85990193bfc14bb88924511ec2d93ad78d536c3 ) I am wondering if a similar approach might be worthwhile, perhaps using legacy-support or legacy-support-devel?

[artkiver (グレェ)]

In d1d41826e7835fe165d2bf4b6b2d2a59d729bb48/macports-ports (master):

rpki-client: update to 8.6 (​https://github.com/macports/macports-ports/pull/20717)

Closes: #67883

[artkiver (グレェ)]

After sleeping on this I realized I may have prematurely closed this because I didn't test on El Capitan, so not seeing the same build error locally wasn't a reflection of that version of OS X. I'll check into it later, but if this is flagged again in the build bots, my apologies! I will re-open it if necessary.