Opened 15 months ago
Closed 15 months ago
#67985 closed defect (fixed)
gtk4 @4.12.0: Should not need to blacklist clang < 1200
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | mascguy (Christopher Nielsen) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.8.1 |
Keywords: | Cc: | ||
Port: | gtk4 |
Description
gtk4 blacklists clang < 1200 because:
../gtk-4.12.0/gdk/x11/gdkglcontext-glx.c:666:56: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] (XSetWindowAttributes[1]) { 0, }); ^ {} 6 warnings and 1 error generated.
But the project is deliberately enabling warnings for this specific error (and others):
Compiler for C supports arguments -Werror=missing-braces: YES
So the developers want to fix these problems, so it should be reported to them so it can be fixed and the blacklist can then be removed.
Alternately, if they will not fix the problem, we should remove -Werror
for this warning, as we already do for another warning. (Why do we do that? Isn't that an upstream issue too?)
Change History (2)
comment:1 Changed 15 months ago by mascguy (Christopher Nielsen)
comment:2 Changed 15 months ago by Christopher Nielsen <mascguy@…>
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Yep, I agree, and will check with upstream. (This was simply a quick fix, to resolve the build issues for 10.14/10.15.)