spice-server: error: visibility does not match previous declaration

[mascguy (Christopher Nielsen)]

Haven't determined the cause yet - perhaps slightly different behaviour across Clang versions, for visibility-related pragmas? - but errors are occurring for a mix of older macOS releases:

inputs-channel.cpp:467:1: error: visibility does not match previous declaration
SPICE_GNUC_VISIBLE int spice_server_kbd_leds(SpiceKbdInstance *sin, int leds)
^
./utils.h:28:44: note: expanded from macro 'SPICE_GNUC_VISIBLE'
#define SPICE_GNUC_VISIBLE __attribute__ ((visibility ("default")))
                                           ^
./push-visibility.h:19:13: note: previous attribute is here
#pragma GCC visibility push(hidden)
            ^
1 error generated.

[kupietools (Michael E. Kupietz)]

Seeing this also, although different errors:

--->  Building spice-server
Error: Failed to build spice-server: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_spice-server/spice-server/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port spice-server failed

The mentioned main.log is enormous and searching for errors in it didn't reveal anything immediately useful.

EDIT: Belay that, when I found the failed make command in the log and ran it manually, I did get the same error.

inputs-channel.cpp:467:1: error: visibility does not match previous declaration
SPICE_GNUC_VISIBLE int spice_server_kbd_leds(SpiceKbdInstance *sin, int leds)
^
./utils.h:28:44: note: expanded from macro 'SPICE_GNUC_VISIBLE'
#define SPICE_GNUC_VISIBLE __attribute__ ((visibility ("default")))
                                           ^
./push-visibility.h:19:13: note: previous attribute is here
#pragma GCC visibility push(hidden)

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #68671.

​Report it to the developers. They'll release a fixed version. Then we can update to it.

[kupietools (Michael E. Kupietz)]

For benefit of people arriving here from search engines in the future: issue now opened with spice-server developers at ​https://gitlab.freedesktop.org/spice/spice/-/issues/84. I think this ticket can probably be closed.

[ryandesign (Ryan Carsten Schmidt)]

In 3ec79463c804856818375888300cf5b1d07641a3/macports-ports (master):

spice-server: Fix build with older clangs

Closes: #68439