aewan @1.0.01_1: error: implicit declaration of function 'filedlg_show' is invalid in C99

[cooljeanius (Eric Gallager)]

Another victim of -Werror=implicit-function-declaration being on by default now:

/usr/bin/clang -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 -fno-strict-aliasing -Wall -c keys.c -o keys.o
debug_aewl.c:22:14: error: implicit declaration of function 'filedlg_show' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
   char *s = filedlg_show("Test Dialog");
             ^
debug_aewl.c:22:10: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion]
   char *s = filedlg_show("Test Dialog");
         ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from helpdlg.c:37:
./helpdlg.h:35:9: warning: '_btco_aewan_helpdlg_h' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef _btco_aewan_helpdlg_h
        ^~~~~~~~~~~~~~~~~~~~~
./helpdlg.h:36:9: note: '_btco_aewan_helprdlg_h' is defined here; did you mean '_btco_aewan_helpdlg_h'?
#define _btco_aewan_helprdlg_h
        ^~~~~~~~~~~~~~~~~~~~~~
        _btco_aewan_helpdlg_h
1 warning and 1 error generated.
aeff.c:91:40: warning: incompatible function pointer types passing 'int (gzFile)' (aka 'int (struct gzFile_s *)') to parameter of type 'int (*)(void *)' [-Wincompatible-function-pointer-types]
   autod_assign( line, freadline_ex(f, gzgetc) );
                                       ^~~~~~
./bores/autod.h:110:53: note: expanded from macro 'autod_assign'
                                      (void**)&ptr, newvalue)
                                                    ^~~~~~~~
./bores/util.h:144:36: note: passing argument to parameter 'readch' here
char *freadline_ex(void *fh, int (*readch)(void*));
                                   ^
make: *** [debug_aewl.o] Error 1
make: *** Waiting for unfinished jobs....
aeff.c:195:42: warning: incompatible function pointer types passing 'int (gzFile)' (aka 'int (struct gzFile_s *)') to parameter of type 'int (*)(void *)' [-Wincompatible-function-pointer-types]
   autod_assign(line, freadline_ex(f->f, gzgetc));
                                         ^~~~~~
./bores/autod.h:110:53: note: expanded from macro 'autod_assign'
                                      (void**)&ptr, newvalue)
                                                    ^~~~~~~~
./bores/util.h:144:36: note: passing argument to parameter 'readch' here
char *freadline_ex(void *fh, int (*readch)(void*));
                                   ^
In file included from handlekey.c:53:
./helpdlg.h:35:9: warning: '_btco_aewan_helpdlg_h' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef _btco_aewan_helpdlg_h
        ^~~~~~~~~~~~~~~~~~~~~
./helpdlg.h:36:9: note: '_btco_aewan_helprdlg_h' is defined here; did you mean '_btco_aewan_helpdlg_h'?
#define _btco_aewan_helprdlg_h
        ^~~~~~~~~~~~~~~~~~~~~~
        _btco_aewan_helpdlg_h
aewan.c:142:14: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
      printw(msg);
             ^~~
aewan.c:142:14: note: treat the string as an argument to avoid this
      printw(msg);
             ^
             "%s", 
1 warning generated.
1 warning generated.
2 warnings generated.
1 warning generated.
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_aewan/aewan/work/aewan-1.0.01'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_aewan/aewan/work/aewan-1.0.01" && /usr/bin/make -j16 -w all 
Exit code: 2
Error: Failed to build aewan: command execution failed
DEBUG: Error code: CHILDSTATUS 12817 2

(I'm on Big Sur with Xcode 13)

[cooljeanius (Eric Gallager)]

main.log for aewan

[ryandesign (Ryan Carsten Schmidt)]

In 22824f11cce6ee398159f175aa89fba0306cb6cc/macports-ports (master):

aewan: Fix compiler errors and warnings

Closes: #68443

Also modernize checksums and remove platforms darwin line.