thrift @0.18.1 fails to build on Sonoma: error: variable 'j' set but not used [-Werror,-Wunused-but-set-variable]

[barracuda156]

/usr/bin/clang++ -std=c++11 -DHAVE_CONFIG_H   -I./src -I/opt/local/libexec/boost/1.76/include -I/opt/local/include -DBOOST_TEST_DYN_LINK -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -Wall -Wextra -pedantic -Werror -pipe -I/opt/local/libexec/boost/1.76/include -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64 -MT src/thrift/generate/thrift-t_javame_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_javame_generator.Tpo -c -o src/thrift/generate/thrift-t_javame_generator.o `test -f 'src/thrift/generate/t_javame_generator.cc' || echo './'`src/thrift/generate/t_javame_generator.cc
src/thrift/generate/t_java_generator.cc:5754:9: error: variable 'j' set but not used [-Werror,-Wunused-but-set-variable]
    int j = 0;
        ^
mv -f src/thrift/generate/.deps/thrift-t_haxe_generator.Tpo src/thrift/generate/.deps/thrift-t_haxe_generator.Po
/usr/bin/clang++ -std=c++11 -DHAVE_CONFIG_H   -I./src -I/opt/local/libexec/boost/1.76/include -I/opt/local/include -DBOOST_TEST_DYN_LINK -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -Wall -Wextra -pedantic -Werror -pipe -I/opt/local/libexec/boost/1.76/include -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64 -MT src/thrift/generate/thrift-t_js_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_js_generator.Tpo -c -o src/thrift/generate/thrift-t_js_generator.o `test -f 'src/thrift/generate/t_js_generator.cc' || echo './'`src/thrift/generate/t_js_generator.cc
mv -f src/thrift/generate/.deps/thrift-t_html_generator.Tpo src/thrift/generate/.deps/thrift-t_html_generator.Po
/usr/bin/clang++ -std=c++11 -DHAVE_CONFIG_H   -I./src -I/opt/local/libexec/boost/1.76/include -I/opt/local/include -DBOOST_TEST_DYN_LINK -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -Wall -Wextra -pedantic -Werror -pipe -I/opt/local/libexec/boost/1.76/include -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64 -MT src/thrift/generate/thrift-t_json_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_json_generator.Tpo -c -o src/thrift/generate/thrift-t_json_generator.o `test -f 'src/thrift/generate/t_json_generator.cc' || echo './'`src/thrift/generate/t_json_generator.cc
1 error generated.
make[3]: *** [src/thrift/generate/thrift-t_java_generator.o] Error 1
make[3]: *** Waiting for unfinished jobs....

[barracuda156]

0.19.0 fails identically.

[ryandesign (Ryan Carsten Schmidt)]

A good example for why we don't like to use -Werror in MacPorts.

The problem was already reported upstream:

​https://github.com/apache/thrift/pull/2855

And the unused variable was removed:

​https://github.com/apache/thrift/commit/bc9c04d8049d7d5f5cf4e63a25226c1fb8c930bf

We could apply this patch to the port.

[Sergey Fedorov <svacchanda@…>]

In f0bdaa2aab141d031b0f51859f3037e59f2c4392/macports-ports (master):

thrift: update to 0.19.0, fix build on Sonoma

Fixes: #68475