Opened 13 months ago
Last modified 13 months ago
#68583 new update
balsa: update to 2.6.4
Reported by: | contextnerror | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | |
Port: | balsa |
Description
Partial portfile, existing patches should be done. I think I've done all I can here.
Attachments (3)
Change History (8)
Changed 13 months ago by contextnerror
Attachment: | balsa.diff added |
---|
Changed 13 months ago by contextnerror
Attachment: | patch-configure.ac.diff added |
---|
Changed 13 months ago by contextnerror
Attachment: | patch-src-sendmsg-window.c.diff added |
---|
comment:1 Changed 13 months ago by ryandesign (Ryan Carsten Schmidt)
What is the purpose of patch-configure.ac.diff? I realize you're just updating an existing patchfile, but why is it there? What problem occurs if the patch is not there? It should be documented at the top of the patchfile, e.g. with a URL to the upstream bug report so that we can check on it periodically to see if upstream has fixed it.
When this patchfile was originally added, it corrected the project's version number, but upstream has fixed that long ago, so if this patch isn't fixing any additional problem, it should be removed.
comment:2 Changed 13 months ago by ryandesign (Ryan Carsten Schmidt)
Confirming that I believe the licensing change from GPL-3 to GPL-2+ is correct according to https://gitlab.gnome.org/GNOME/balsa/-/issues/27.
Replying to contextnerror:
Partial portfile, existing patches should be done. I think I've done all I can here.
Does it work for you? What more do you believe needs to be done?
comment:3 follow-up: 4 Changed 13 months ago by contextnerror
What is the purpose of patch-configure.ac.diff?
I'm not entirely sure myself. But it won't configure without it. When comparing with and without patch, running without the patch gives this warning at autoconf before failing:
Running autoconf... configure.ac:23: warning: AC_DEFINE_UNQUOTED: `"-n 2.6.4 configure.ac:23: "' is not a valid preprocessor define value Running autoheader... Running automake... configure.ac:25: installing './compile' configure.ac:14: installing './missing' libbalsa/Makefile.am: installing './depcomp' libnetclient/test/Makefile.am:4: warning: shell echo $(abs_srcdir: non-POSIX variable name libnetclient/test/Makefile.am:4: (probably a GNU make extension) src/Makefile.am:106: warning: shell $(GLIB_COMPILE_RESOURCES: non-POSIX variable name src/Makefile.am:106: (probably a GNU make extension) src/Makefile.am:148: warning: shell $(GLIB_COMPILE_RESOURCES: non-POSIX variable name src/Makefile.am:148: (probably a GNU make extension) Running configure --prefix=/opt/local --with-gtksourceview --with-spell-checker=gspell --with-html-widget=webkit2 --with-sqlite --with-libsecret --with-gnome --disable-more-warnings --disable-silent-rules ... /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_balsa/balsa/work/balsa-2.6.4/configure: line 4: .: filename argument required .: usage: . filename [arguments] Command failed: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_balsa/balsa/work/balsa-2.6.4" && ./autogen.sh --prefix=/opt/local --with-gtksourceview --with-spell-checker=gspell --with-html-widget=webkit2 --with-sqlite --with-libsecret --with-gnome --disable-more-warnings --disable-silent-rules Exit code: 2 Error: Failed to configure balsa: configure failure: command execution failed
With the patch autoconf gives no warnings and the configure phase completes fine (to my knowledge).
Does it work for you?
No, it doesn't. In its current state in this ticket, it fails during the build phase.
Undefined symbols for architecture x86_64: "_webkit_website_data_manager_set_tls_errors_policy", referenced from: _lbh_get_web_view_context in libbalsa.a(html.o) ld: symbol(s) not found for architecture x86_64
This error means nothing to me. Obviously I think it should be fixed, but I can't say how.
comment:4 Changed 13 months ago by ryandesign (Ryan Carsten Schmidt)
comment:5 Changed 13 months ago by contextnerror
I think it's https://gitlab.gnome.org/GNOME/balsa/-/issues
Portfile in progress