Opened 12 months ago

Closed 8 months ago

#68720 closed defect (fixed)

ffmpeg6 @6.1_0: error: use of undeclared identifier 'kVTCompressionPropertyKey_EncoderID'

Reported by: tehcog (tehcog) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version: 2.8.1
Keywords: mavericks Cc:
Port: ffmpeg6

Description

please see attached main.log

Attachments (1)

ffmpeg6_main.log​ (3.8 MB) - added by tehcog (tehcog) 12 months ago.
main.log

Change History (11)

Changed 12 months ago by tehcog (tehcog)

Attachment: ffmpeg6_main.log​ added

main.log

comment:1 Changed 12 months ago by ryandesign (Ryan Carsten Schmidt)

Keywords: mavericks added
Summary: ffmpeg6 6.0_4 < 6.1_0 fails to upgrade on mavericks → ffmpeg6 @6.1_0: error: use of undeclared identifier 'kVTCompressionPropertyKey_EncoderID' 
libavcodec/videotoolboxenc.c:1185:40: error: use of undeclared identifier 'kVTCompressionPropertyKey_EncoderID'; did you mean 'kVTCompressionPropertyKey_Depth'?
                                       kVTCompressionPropertyKey_EncoderID,
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                       kVTCompressionPropertyKey_Depth
/System/Library/Frameworks/VideoToolbox.framework/Headers/VTCompressionProperties.h:314:29: note: 'kVTCompressionPropertyKey_Depth' declared here
VT_EXPORT const CFStringRef kVTCompressionPropertyKey_Depth VT_AVAILABLE_STARTING(10_8); // Read/write, CFNumber (CMPixelFormatType), Optional
                            ^
1 error generated.

Indeed kVTCompressionPropertyKey_EncoderID was introduced in macOS 10.13.

comment:3 Changed 12 months ago by mascguy (Christopher Nielsen)

Cc: mascguy removed
Owner: set to mascguy
Status: new → assigned

comment:4 Changed 12 months ago by aeiouaeiouaeiouaeiouaeiouaeiou

Reported in upstream FFmpeg trac: ​https://trac.ffmpeg.org/ticket/10695

comment:5 Changed 11 months ago by aeiouaeiouaeiouaeiouaeiouaeiou

The master branch has recently pushed these two commits:

​https://github.com/FFmpeg/FFmpeg/commit/cb049d377f54f6b747667a93e4b719380c3e9475.patch

​https://github.com/FFmpeg/FFmpeg/commit/d526a34c20647f54a2cd8f5871b7dc24214578fe.patch

Can someone add these patches to portfile and see what happens? I'm not using the affected systems at this time.

comment:6 in reply to:  5 Changed 11 months ago by tehcog (tehcog)

Replying to aeiouaeiouaeiouaeiouaeiouaeiou:

Can someone add these patches to portfile and see what happens? I'm not using the affected systems at this time.

Sure, just tell me how to do it. Will the diff's work as they exists in their commit, or do they need to be modified to work with our port file?

Thanks

comment:7 Changed 11 months ago by tehcog (tehcog)

FYI this is still an issue when upgrading: 

ffmpeg6  6.0_4 < 6.1_1

:info:build libavcodec/videotoolboxenc.c:1185:40: error: use of undeclared identifier 'kVTCompressionPropertyKey_EncoderID'; did you mean 'kVTCompressionPropertyKey_Depth'?
:info:build                                        kVTCompressionPropertyKey_EncoderID,
:info:build                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build                                        kVTCompressionPropertyKey_Depth
:info:build /System/Library/Frameworks/VideoToolbox.framework/Headers/VTCompressionProperties.h:314:29: note: 'kVTCompressionPropertyKey_Depth' declared here
:info:build VT_EXPORT const CFStringRef kVTCompressionPropertyKey_Depth VT_AVAILABLE_STARTING(10_8); // Read/write, CFNumber (CMPixelFormatType), Optional
:info:build                             ^
:info:build 1 error generated.

thank you

comment:8 in reply to:  7 ; Changed 11 months ago by mascguy (Christopher Nielsen)

Replying to tehcog:

FYI this is still an issue when upgrading: 

ffmpeg6  6.0_4 < 6.1_1

:info:build libavcodec/videotoolboxenc.c:1185:40: error: use of undeclared identifier 'kVTCompressionPropertyKey_EncoderID'; did you mean 'kVTCompressionPropertyKey_Depth'?
:info:build                                        kVTCompressionPropertyKey_EncoderID,
:info:build                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build                                        kVTCompressionPropertyKey_Depth
:info:build /System/Library/Frameworks/VideoToolbox.framework/Headers/VTCompressionProperties.h:314:29: note: 'kVTCompressionPropertyKey_Depth' declared here
:info:build VT_EXPORT const CFStringRef kVTCompressionPropertyKey_Depth VT_AVAILABLE_STARTING(10_8); // Read/write, CFNumber (CMPixelFormatType), Optional
:info:build                             ^
:info:build 1 error generated.

Yes indeed, this is still on my to-do list. Thanks for the reminder!

comment:9 in reply to:  8 Changed 8 months ago by aeiouaeiouaeiouaeiouaeiouaeiou

Replying to mascguy:

Yes indeed, this is still on my to-do list.

Bump: these commits still haven't backported to the stable version, but I definitely think they will fix this issue. I can't deploy pre-Sierra VM for tests because it takes too long with my HDD.

comment:10 Changed 8 months ago by Christopher Nielsen <mascguy@…>

Resolution: → fixed
Status: assigned → closed

In d2f9f6bb49a41d643b1c975e2bcfd6805e0ca2d5/macports-ports (master):

ffmpeg6: add upstream patch, for earlier macOS releases

  • Failure Specifics: error: use of undeclared identifier 'kVTCompressionPropertyKey_EncoderID'
  • Note: Since this patch is applied unconditionally, rev-bump to rebuild across-the-board.

Fixes: #68720

Note: See TracTickets for help on using tickets.