ffmpeg @4.4.4_3 fails to build

[gwright83]

ffmpeg 4.4.4_3 fails to build because texinfo is now at version 7.1. Version 7.1 changed certain function names; the failure is in building documentation:

:info:build makeinfo --html -I doc --no-split -D config-not-all --init-file=./doc/t2h.pm --output doc/ffmpeg.html doc/ffmpeg.texi
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
:info:build gmake: *** [doc/Makefile:67: doc/ffprobe.html] Error 1
:info:build gmake: *** Waiting for unfinished jobs....
:info:build gmake: *** [doc/Makefile:71: doc/ffplay-all.html] Error 1
:info:build gmake: *** [doc/Makefile:71: doc/ffprobe-all.html] Error 1

There are patches to ffmpeg to work around this but they have evidently not been applied to the current macport 4.4.x version. See ​https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/f01fdedb69e4accb1d1555106d8f682ff1f1ddc7

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #68755.

[maxcrees (Max Rees)]

The upstream diff linked in the original description does not apply cleanly to 4.4.4_3 sources. I've attached a backported patch which allows the port to build.

[astroboylrx (Rixin Li)]

Replying to maxcrees:

The upstream diff linked in the original description does not apply cleanly to 4.4.4_3 sources. I've attached a backported patch which allows the port to build.

Do you mind explaining how one may use this patch to build a port? Or giving a link to an example? Thank you very much in advance!!

[rickyzhang82 (Ricky Zhang)]

RTFM ​https://guide.macports.org/#development.local-repositories

or my gitst here ​https://gist.github.com/rickyzhang82/40f7116508a1782cd1c0268b8828b970#another-user-guide

Follow the instructions above. Skip step 4. Drop the attached diff file to files folder and add the line to the Portfile:

patchfiles-append   patch-texinfo-7.diff

The diff works.

[mascguy (Christopher Nielsen)]

I'm sorry for the delay on this folks, I've been consumed with work for my day job lately. Thankfully I have some time over the Thanksgiving holiday though, and will take care of the various open tickets like this.

More to follow, over the next few days.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #68772.

[maxcrees (Max Rees)]

PR 21526 submitted ​https://github.com/macports/macports-ports/pull/21526

[Max Rees <maxcrees@…>]

In afca66901e6c061aaa4bb2012334440a70184f42/macports-ports (master):

ffmpeg{,-devel}: fix build with texinfo >= 7

Fixes: #68747

[kemar (Marc Hertzog)]

Thanks guys!