collectd @5.12.0: error: variable 'num_entries' set but not used

[FranklinYu (Franklin Yu)]

Relevant error message (from the MacPorts log file):

src/bind.c:473:7: error: variable 'num_entries' set but not used [-Werror,-Wunused-but-set-variable]
  int num_entries = 0;
      ^
src/bind.c:552:7: error: variable 'num_entries' set but not used [-Werror,-Wunused-but-set-variable]
  int num_entries = 0;
      ^
src/bind.c:612:7: error: variable 'num_entries' set but not used [-Werror,-Wunused-but-set-variable]
  int num_entries = 0;
      ^
3 errors generated.
make[1]: *** [src/bind_la-bind.lo] Error 1
make: *** [all] Error 2

I was able to reproduce this after running sudo -u macports make in the build-directory.

[FranklinYu (Franklin Yu)]

I feel that -Werror is only useful in ./configure (to detect features), or during CI build (for development). Building on end-user machine sounds more harmful than helpful.

I found that it was specified in Makefile:

AM_CFLAGS = -Wall -Werror
AM_CXXFLAGS = -Wall -Werror

I removed -Werror from the Makefile, which allows me to build. I also noticed ​https://github.com/macports/macports-ports/blob/64319d031f9710587acc643b6a7eace717261a23/sysutils/collectd/Portfile#L34. Have we escalated to upstream about this issue (to see whether they are willing to make -Werror optional)?

[FranklinYu (Franklin Yu)]

I noticed that the AUR package has --disable-werror: ​https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=collectd#n67

Maybe it can help?

[neverpanic (Clemens Lang)]

​https://github.com/macports/macports-ports/pull/21784

[neverpanic (Clemens Lang)]

In 2e8b574962a708a5fb0dda8583930995440de760/macports-ports (master):

collectd: Disable -Werror

Closes: #68896