Opened 10 months ago
Last modified 7 months ago
#69117 assigned defect
harfbuzz fails to compile on 10.5
| Reported by: | rmottola (Riccardo) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | leopard | Cc: | mascguy (Christopher Nielsen) |
| Port: | harfbuzz |
Description
I get this error on 10.5 32bit intel:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_harfbuzz/harfbuzz/work/harfbuzz-8.3.0/src/hb-coretext.h:33:5: error: 'TARGET_OS_IPHONE' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
#if TARGET_OS_IPHONE
^
1 error generated.
Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/setuptools/_distutils/unixccompiler.py", line 178, in preprocess
Attachments (1)
Change History (6)
comment:1 Changed 10 months ago by rmottola (Riccardo)
comment:2 Changed 10 months ago by kencu (Ken)
I think just go ahead and add legacysupport to all these, and see if that fixes them.
comment:3 Changed 10 months ago by jmroot (Joshua Root)
| Cc: | mascguy added |
|---|---|
| Owner: | set to ryandesign |
| Status: | new → assigned |
Not hard to patch in a way that should be acceptable for upstream. https://github.com/macports/macports-ports/blob/c3497fe523f1b185d51b2013a12883aafdec7e0e/net/nss/files/undef-prefix.patch
Changed 10 months ago by rmottola (Riccardo)
| Attachment: | harfbuzz_hb-coretext.patch added |
|---|
define patch for harfbuzz
comment:4 Changed 10 months ago by rmottola (Riccardo)
I attached a patch that works fine for me. Same principle. It should be upstreamable, but also fine to apply unconditionally in macports?
comment:5 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)
In MacPorts we prefer not to carry patches around forever. Feel free to file a bug report or pull request with the developers of harfbuzz. If they agree this is the right solution and commit it to their repository, I'm happy to add it to MacPorts.
I notice a similarity to #69116 Completely different file, code and place.. I wonder if it is by chance with the original code, or if it comes from something from macports, legacy support or such?