cdrtools: uses pulseaudio opportunistically; needs revbump for latest pulseaudio update

[Gandoon (Erik Hedlund)]

The recent update to pulseaudio breaks cdrtools on MacOS 10.15 and possibly other systems.

While it is possible to build and install cdrtools, the subsequent rev-upgrade gives the following:

--->  Cleaning cdrtools
--->  Removing work directory for cdrtools
--->  Scanning binaries for linking errors
Incompatible library version: /opt/local/bin/cdda2wav requires version 24.0.0 or later, but /opt/local/lib/libpulse.0.dylib provides version 0.0.0
Incompatible library version: /opt/local/bin/cdda2wav requires version 2.0.0 or later, but /opt/local/lib/libpulse-simple.0.dylib provides version 0.0.0
--->  Found 2 broken files, matching files to ports
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: cdrtools @3.02-2023-09-28

It is worth noting that the older pulseaudio @14.2_1+esound+jack+x11 does pass the rev-upgrade. No logs are attached as the full installation succeeded for both ports and the build directories were removed. The issue did not show until the rev-upgrade stage.

I should maybe mention that there are other issues with the source for cdrtools that probably does merit a separate ticket though, as it does not build without removing register keywords from the code in various places (it seems to be unsupported by the compiler used). For that issue, see that ticket (I will try to remember to link it here when I have created it).

[ryandesign (Ryan Carsten Schmidt)]

I guess the real bug is: cdrtools uses pulseaudio without declaring a dependency on it. If it had declared a dependency on it, it would have been revbumped along with all the other ports that depend on pulseaudio in [2db392c089e181e14ec65df019a50a266a49db81/macports-ports] after pulseaudio was updated.

[kencu (Ken)]

looks like with the switch to meson, the library versioning is wrong now.

 /opt/local/lib/libpulse.0.dylib provides version 0.0.0

[Gandoon (Erik Hedlund)]

Replying to kencu:

looks like with the switch to meson, the library versioning is wrong now.

 /opt/local/lib/libpulse.0.dylib provides version 0.0.0

Indeed. Thus I will keep the old pulseaudio library at hand for the time being. Being a bit busy (trying to find a job as a biophysicist here), I didn't have time to dig into this to find a solution, especially as I am not very familiar with the code base for neither pulseaudio nor cdrtools.

[RobK88]

I do not know how to fix this bug. I cannot reproduce it.

FYI - cdrtools does declare a dependency on pulseaudio.

depends_lib-append      port:gettext-runtime \
                        port:libiconv \
                        port:pulseaudio

Perhaps it is a meson bug..

[RobK88]

FYI - I have updated cdrtools to the latest version.

See Pull Request: ​​https://github.com/macports/macports-ports/pull/23654

I am not sure if this fixes the bug reported here or not since I cannot reproduce the bug here.

[RobK88]

FYI -- The PR has been merged. Please let me know if the problem persists.

See ​https://github.com/macports/macports-ports/pull/23654

[Gandoon (Erik Hedlund)]

Replying to RobK88:

FYI -- The PR has been merged. Please let me know if the problem persists.

See ​https://github.com/macports/macports-ports/pull/23654

Sorry for the delayed response, but I just got around to building it. cdrtools @3.02-2024-03-21_0 built just fine and I had no problems combining with pulseaudio @17.0_0+jack+x11. I didn't even have those pesky complaints about register keywords.

All in all, I think this issue is fixed with that merge. Unless something hidden pops up, I think we can close this ticket.

[mascguy (Christopher Nielsen)]

Replying to Gandoon:

Replying to RobK88:

FYI -- The PR has been merged. Please let me know if the problem persists.

See ​https://github.com/macports/macports-ports/pull/23654

Sorry for the delayed response, but I just got around to building it. cdrtools @3.02-2024-03-21_0 built just fine and I had no problems combining with pulseaudio @17.0_0+jack+x11. I didn't even have those pesky complaints about register keywords.

All in all, I think this issue is fixed with that merge. Unless something hidden pops up, I think we can close this ticket.

Great, glad the issue is resolved!