#69343 closed update (fixed)
yaml-cpp: Update to 0.8.0
Reported by: | DanielO (Daniel O'Connor) | Owned by: | judaew (Vadym-Valdis Yudaiev) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | |
Port: | yaml-cpp |
Description
Update yaml-cpp to 0.8.0, I removed the special handling and patch as they did not seem necessary but perhaps I am missing something .
Attachments (1)
Change History (7)
Changed 9 months ago by DanielO (Daniel O'Connor)
Attachment: | yaml-cpp-update.diff added |
---|
comment:1 Changed 9 months ago by DanielO (Daniel O'Connor)
Port: | yaml-cpp added |
---|
comment:2 Changed 9 months ago by ryandesign (Ryan Carsten Schmidt)
Owner: | set to judaew |
---|---|
Status: | new → assigned |
comment:3 Changed 9 months ago by judaew (Vadym-Valdis Yudaiev)
The yaml-cpp
project changed their tag naming strategy broke livecheck. So I didn't know there was a new version. Thank you!
comment:4 Changed 9 months ago by judaew (Vadym-Valdis Yudaiev)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:5 Changed 9 months ago by l2dy (Zero King)
Dependent ports may need revbump, e.g. micromamba.
dyld[90494]: Library not loaded: /opt/local/lib/libyaml-cpp.0.7.dylib Referenced from: <A765447D-AD6F-373A-9844-8AF3F38F1D44> /opt/local/bin/micromamba Reason: tried: '/opt/local/lib/libyaml-cpp.0.7.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/local/lib/libyaml-cpp.0.7.dylib' (no such file), '/opt/local/lib/libyaml-cpp.0.7.dylib' (no such file)
comment:6 Changed 9 months ago by judaew (Vadym-Valdis Yudaiev)
Note: See
TracTickets for help on using
tickets.
Replying to DanielO:
Thanks! The revision needs to drop to 0 when the version is updated. Whoever applies this patch can make that additional change.
If you mean the "yaml-cpp-" fourth argument to
github.setup
(that's the only other change I see in your patch) then yes, this change is correct. The yaml-cpp project used to use the "yaml-cpp-" prefix on their tags. For example, the tag for version 0.7.0 was "yaml-cpp-0.7.0". With version 0.8.0 they have changed their tag naming strategy and are not using a tag prefix anymore. For example, the tag for version 0.8.0 is "0.8.0".The patch was accepted upstream and is included in 0.8.0 so it is correct to remove the patch now.