npth @1.7 does not build on PPC Tiger, Mac OS X 10.4.11, because patching fails

[ballapete (Peter "Pete" Dyballa)]

--->  Extracting npth-1.7.tar.bz2
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_npth/npth/work" && /opt/local/bin/lbzip2 -dc '/opt/local/var/macports/distfiles/npth/npth-1.7.tar.bz2' | /usr/bin/gnutar --no-same-owner -xf - 
--->  Applying patches to npth
--->  Applying use-darwin-compat.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_npth/npth/work/npth-1.7" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/tarballs/ports/devel/npth/files/use-darwin-compat.diff'
patching file src/Makefile.am
Hunk #1 FAILED at 31.
1 out of 1 hunk FAILED -- saving rejects to file src/Makefile.am.rej
patching file src/npth.c
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_npth/npth/work/npth-1.7" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/tarballs/ports/devel/npth/files/use-darwin-compat.diff'
Exit code: 1
Error: Failed to patch npth: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_npth/npth/main.log for details.

Cause is

diff npth-1.6/src/Makefile.am npth-1.7/src/Makefile.am
33c33
< libnpth_la_SOURCES = npth.h npth.c npth-sigev.c
---
> libnpth_la_SOURCES = npth.c npth-sigev.c

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Tiger, Mac OS X 10.4.11

[ballapete (Peter "Pete" Dyballa)]

Patch for npth v. 1.7

[ballapete (Peter "Pete" Dyballa)]

With the attached and updated patch npth @1.7 built.

[ballapete (Peter "Pete" Dyballa)]

This version identifies itself as 1.7-unknown – would it make sense to rename it to 1.7-Darwin? It is away from the original version…

[ballapete (Peter "Pete" Dyballa)]

I made the npth maintainers aware of the changes needed to make it work on Tiger and Leopard: ​https://dev.gnupg.org/T7057.

[ballapete (Peter "Pete" Dyballa)]

NIIBE Yutaka created a git patch that solves the problem on Tiger. I then converted this patch into unified format. it's attached here. gpg-agent launches and can be killed as well. Portfile need to be changed from

platform darwin {
    if {${os.major} < 10 || (${os.major} == 10 && ${configure.build_arch} eq "ppc")} {
        post-extract {
            copy ${filespath}/darwin_compat.h ${worksrcpath}/src/
            copy ${filespath}/darwin_compat.c ${worksrcpath}/src/
        }   
        patchfiles-append   use-darwin-compat.diff
        use_autoreconf      yes 
        autoreconf.args     -fvi
    }   
}

to simple

platform darwin {
    if {${os.major} < 10 || (${os.major} == 10 && ${configure.build_arch} eq "ppc")} {
        patchfiles-append   npth-unnamed-semaphores-on-tiger-and-leopard.diff
        use_autoreconf      yes
        autoreconf.args     -fvi
    }
}

[ballapete (Peter "Pete" Dyballa)]

New patch for unnamed semaphores on Tiger and Leopard

[ballapete (Peter "Pete" Dyballa)]

It is installed since over a month: npth @1.7_1 (active) requested_variants='' platform='darwin 8' archs='ppc' date='2024-03-26T10:23:09+0100'.

[ryandesign (Ryan Carsten Schmidt)]

But what you've installed is something custom to your machine. You have version 1.7 revision 1 but I don't know what that is; the newest we have in MacPorts is 1.7 revision 0.

[ballapete (Peter "Pete" Dyballa)]

It's built with the corrected/updated patch.