Opened 8 months ago

Closed 8 months ago

#69561 closed defect (fixed)

lite-xl fails to build on 10.6: error: 'kFSEventStreamCreateFlagFileEvents' undeclared

Reported by: barracuda156 Owned by: barracuda156
Priority: Normal Milestone:
Component: ports Version: 2.9.1
Keywords: tiger, leopard, snowleopard Cc: harens (Haren S)
Port: lite-xl

Description (last modified by barracuda156)

[12/14] /opt/local/bin/gcc-mp-13 -Isrc/lite-xl.p -Isrc -I../lite-xl-2.1.2/src -I/opt/local/include/SDL2 -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include -fdiagnostics-color=always -Wall -Winvalid-pch -std=gnu11 -O3 -pipe -Os -arch ppc -D_THREAD_SAFE -DSDL_MAIN_HANDLED -DPCRE2_STATIC -DLITE_USE_SDL_RENDERER '-DLITE_ARCH_TUPLE="ppc-darwin"' -MD -MQ src/lite-xl.p/api_dirmonitor_fsevents.c.o -MF src/lite-xl.p/api_dirmonitor_fsevents.c.o.d -o src/lite-xl.p/api_dirmonitor_fsevents.c.o -c ../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c
FAILED: src/lite-xl.p/api_dirmonitor_fsevents.c.o 
/opt/local/bin/gcc-mp-13 -Isrc/lite-xl.p -Isrc -I../lite-xl-2.1.2/src -I/opt/local/include/SDL2 -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include -fdiagnostics-color=always -Wall -Winvalid-pch -std=gnu11 -O3 -pipe -Os -arch ppc -D_THREAD_SAFE -DSDL_MAIN_HANDLED -DPCRE2_STATIC -DLITE_USE_SDL_RENDERER '-DLITE_ARCH_TUPLE="ppc-darwin"' -MD -MQ src/lite-xl.p/api_dirmonitor_fsevents.c.o -MF src/lite-xl.p/api_dirmonitor_fsevents.c.o.d -o src/lite-xl.p/api_dirmonitor_fsevents.c.o -c ../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c: In function 'stop_monitor_stream':
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c:43:5: warning: implicit declaration of function 'write'; did you mean 'fwrite'? [-Wimplicit-function-declaration]
   43 |     write(monitor->fds[1], "", 1);
      |     ^~~~~
      |     fwrite
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c:44:5: warning: implicit declaration of function 'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
   44 |     close(monitor->fds[0]);
      |     ^~~~~
      |     pclose
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c: In function 'get_changes_dirmonitor':
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c:112:3: warning: implicit declaration of function 'read'; did you mean 'fread'? [-Wimplicit-function-declaration]
  112 |   read(monitor->fds[0], response, 1);
      |   ^~~~
      |   fread
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c: In function 'add_dirmonitor':
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c:149:3: warning: implicit declaration of function 'pipe' [-Wimplicit-function-declaration]
  149 |   pipe(monitor->fds);
      |   ^~~~
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c:172:9: error: 'kFSEventStreamCreateFlagFileEvents' undeclared (first use in this function); did you mean 'kFSEventStreamCreateFlagNoDefer'?
  172 |       | kFSEventStreamCreateFlagFileEvents
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         kFSEventStreamCreateFlagNoDefer
../lite-xl-2.1.2/src/api/dirmonitor/fsevents.c:172:9: note: each undeclared identifier is reported only once for each function it appears in
[13/14] /opt/local/bin/gcc-mp-13 -Isrc/lite-xl.p -Isrc -I../lite-xl-2.1.2/src -I/opt/local/include/SDL2 -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include -fdiagnostics-color=always -Wall -Winvalid-pch -O3 -pipe -Os -arch ppc -D_THREAD_SAFE -DSDL_MAIN_HANDLED -DPCRE2_STATIC -DLITE_USE_SDL_RENDERER '-DLITE_ARCH_TUPLE="ppc-darwin"' -MD -MQ src/lite-xl.p/bundle_open.m.o -MF src/lite-xl.p/bundle_open.m.o.d -o src/lite-xl.p/bundle_open.m.o -c ../lite-xl-2.1.2/src/bundle_open.m
ninja: build stopped: subcommand failed.

Apparently those symbols are present in 10.7+, see also #64584

Opened an issue with upstream: https://github.com/lite-xl/lite-xl/issues/1753

Change History (3)

comment:1 Changed 8 months ago by barracuda156

Description: modified (diff)

comment:2 Changed 8 months ago by barracuda156

With minimal fixes I got it working on 10.6 (both ppc and i386).

Will make a PR soon.

comment:3 Changed 8 months ago by barracuda156

Owner: set to barracuda156
Resolution: fixed
Status: newclosed

In a7171c21580478d3495352a85fa1e243c7c6878e/macports-ports (master):

lite-xl: allow building on < 10.7

Fixes: #69561

Note: See TracTickets for help on using tickets.