Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#69590 closed defect (fixed)

py-uncompyle6: requires a newer version of py-xdis

Reported by: rocky (R. Bernstein) Owned by: reneeotten (Renee Otten)
Priority: Normal Milestone:
Component: ports Version: 2.9.1
Keywords: Cc:
Port: py-uncompyle6

Description

I see that uncompyle6 has been recently updated, but xdis has not. This is not going to work out well.

Change History (4)

comment:1 Changed 8 months ago by reneeotten (Renee Otten)

Owner: set to reneeotten
Port: py-uncompyle6 added; py310-uncompyle6 removed
Status: newaccepted
Summary: A newer version of uncompyle6 requires a newer version of xdispy-uncompyle6: requires a newer version of py-xdis

thanks for the ticket, it's always appreciate when upstream chimes in! I jumped the gun here indeed and updated the package without looking carefully enough at the dependencies - I will try to correct that shortly.

There is a build issue regardless (at least I think) of the dependency problem in that the PEP517 build we use complains about ModuleNotFoundError: No module named '__pkginfo__' - a build log can be found here. I haven't had much time to look at this and perhaps there is a trivial fix, any pointers from you here would be appreciated.

Thanks again, and I will try to get this resolved soon-ish.

comment:2 Changed 8 months ago by ryandesign (Ryan Carsten Schmidt)

Milestone: MacPorts 2.9.2

The Milestone field is only used when the Component field is "base".

comment:3 Changed 8 months ago by reneeotten (Renee Otten)

Resolution: fixed
Status: acceptedclosed

In d9c27fc6761d9d0cc2f41e21cca6d171814cdf8f/macports-ports (master):

py-uncompyle6: fix build failure, add py31{1,2} subports

Closes: #69590

comment:4 Changed 8 months ago by reneeotten (Renee Otten)

hi Rocky, okay I've made the required changes to update py-xdis and get py-uncompyle6 to build. It appears to me that one has to remove the setup.py file and then add the following two lines to pyproject.toml to get things working:

[tool.setuptools.packages.find]
include = ["uncompyle6"]

that allows me to build it for Python 3.8 - 3.12.

The only thing that I can't easily get to work is running the test-suite with newer Python versions. It does work with Python 3.8 where it selects check-3.8 as the test target, but for other Python versions I can't get it to run. I do notice though that you are also not testing anything with newer Python versions in your CI so perhaps that's why the appropriate targets are not defined? Anyway, I think this is resolved now but if you have any other thoughts/suggestions please feel free to respond here and I will take a look.

Note: See TracTickets for help on using tickets.