Opened 8 months ago

Closed 8 months ago

#69653 closed defect (fixed)

mkvtoolnix-legacy: move fallback versions for legacy systems from mkvtoolnix port and do not force Qt5 unconditionally

Reported by: barracuda156 Owned by: i0ntempest
Priority: Normal Milestone:
Component: ports Version: 2.9.2
Keywords: snowleopard, leopard, tiger Cc: ryandesign (Ryan Carsten Schmidt), i0ntempest
Port: mkvtoolnix-legacy

Description

I would expect a -legacy port to support legacy systems, but this one requires Qt5, which is broken on those. It also wants Qt5 5.9 minimum, while 10.6.8 on Intel has 5.3.

Could we please support Qt4 too?

Change History (9)

comment:1 Changed 8 months ago by i0ntempest

Supporting older qt5 versions requires older versions (like the current mkvtoolnix port), which I am planning to do later. But I don't think this port ever supported qt4.

comment:2 in reply to:  1 ; Changed 8 months ago by barracuda156

Replying to i0ntempest:

Supporting older qt5 versions requires older versions (like the current mkvtoolnix port), which I am planning to do later. But I don't think this port ever supported qt4.

Ok, if no Qt4 support existed, then perhaps just disable qtgui for systems where it cannot be supported? And include qt5 PG conditionally.

  1. S. By the way, what is the point of having a separate port, when existing one supports older systems with fallbacks already? https://github.com/macports/macports-ports/blob/d2f9f6bb49a41d643b1c975e2bcfd6805e0ca2d5/multimedia/mkvtoolnix/Portfile

comment:3 in reply to:  2 ; Changed 8 months ago by i0ntempest

Replying to barracuda156:

Ok, if no Qt4 support existed, then perhaps just disable qtgui for systems where it cannot be supported? And include qt5 PG conditionally.

Building (at least for v81) requires qt regardless if qt gui is enabled or not.

  1. S. By the way, what is the point of having a separate port, when existing one supports older systems with fallbacks already? https://github.com/macports/macports-ports/blob/d2f9f6bb49a41d643b1c975e2bcfd6805e0ca2d5/multimedia/mkvtoolnix/Portfile

Because soon it will not. See https://trac.macports.org/ticket/69030. Submitting a legacy port is part of the preparation to update the main port to v83 which is qt6 only.

Last edited 8 months ago by i0ntempest (previous) (diff)

comment:4 in reply to:  3 Changed 8 months ago by barracuda156

Replying to i0ntempest:

Replying to barracuda156:

Ok, if no Qt4 support existed, then perhaps just disable qtgui for systems where it cannot be supported? And include qt5 PG conditionally.

Building (at least for v81) requires qt regardless if qt gui is enabled or not.

Ok, got it. Then we just need to move fallback version from mkvtoolnix port to here, that will solve the problem.

  1. S. By the way, what is the point of having a separate port, when existing one supports older systems with fallbacks already? https://github.com/macports/macports-ports/blob/d2f9f6bb49a41d643b1c975e2bcfd6805e0ca2d5/multimedia/mkvtoolnix/Portfile

Because soon it will not. See https://trac.macports.org/ticket/69030. Submitting a legacy port is part of the preparation to update the main port to v83 which is qt6 only.

Thank you for explanation, I did not see that ticket.

  1. S. It’s a shame that it requires Qt5 even without GUI, and does not have GTK option…

comment:5 Changed 8 months ago by barracuda156

Summary: mkvtoolnix-legacy: support Qt4 where Qt5 unavailablemkvtoolnix-legacy: move fallback versions for legacy systems from mkvtoolnix port and do not force Qt5 unconditionally

comment:6 Changed 8 months ago by i0ntempest

I took a closer look at the old change logs. Qt 5.9 is only required for building the GUI, so if we disable it older Qt 5 versions might work (as in the current port, v41 without GUI builds fine on 10.10 down to 10.6, and the 5.9 requirement was added with v40 for GUI).

Seems like that the main port has multiple versions only because of system C++ library requirements. Currently the legacy port builds fine on 10.11 and up. So maybe we CAN just disable GUI for 10.10 and below and v81 MIGHT work since we now have legacysupport libcxx.

comment:7 Changed 8 months ago by i0ntempest

Owner: set to i0ntempest
Resolution: fixed
Status: newclosed

In 8f0555d61c3f763ce6d83a1878eca5278bf873e6/macports-ports (master):

mkvtoolnix-gui: disable gui where unsupported

Closes: #69653

comment:8 Changed 8 months ago by i0ntempest

Resolution: fixed
Status: closedreopened

Nevermind - still have to do version fallbacks.

comment:9 Changed 8 months ago by i0ntempest

Resolution: fixed
Status: reopenedclosed

Version fallback is up and this port now builds on 10.9 to 14.0. po4a is blocking build on 10.8 and below. Feel free to add yourself as maintainer if you want to make futher tweaks.

Note: See TracTickets for help on using tickets.