Opened 6 weeks ago

Last modified 7 days ago

#69795 new defect

t1lib 5.1.2_3: has implicit int which is not supported under Xcode 15

Reported by: rbeyer (Ross Beyer) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.9.3
Keywords: Cc:
Port: t1lib

Description

Upon trying to build t1lib (for texlive), it failed to build with this error:

:info:build regions.c:602:45: error: parameter 'y2' was not declared, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

There was another of the same kind for x2 but this likely another issue with Xcode 15 being more strict than the past. Hopefully this is another easy port fix.

Attachments (1)

t1lib-main.log (205.5 KB) - added by rbeyer (Ross Beyer) 6 weeks ago.
main.log file from run of port install t1lib

Download all attachments as: .zip

Change History (5)

Changed 6 weeks ago by rbeyer (Ross Beyer)

Attachment: t1lib-main.log added

main.log file from run of port install t1lib

comment:1 Changed 6 weeks ago by jmroot (Joshua Root)

Red Hat has some patches that should help: https://src.fedoraproject.org/rpms/t1lib/tree/rawhide

We should also make sure it uses an appropriately old standard like -std=gnu89 since this issue is on top of the fact that the code uses K&R style declarations, which are no longer allowed as of C23.

comment:2 Changed 3 weeks ago by rbeyer (Ross Beyer)

I don't have the expertise to fix this, and was hoping that someone else might be able to patch up this portfile? It is currently blocking my ability to build texlive, and may be a blocker for others. Thank you.

comment:3 Changed 7 days ago by rbeyer (Ross Beyer)

I can confirm that by applying the simple fix in

https://src.fedoraproject.org/rpms/t1lib/blob/rawhide/f/t1lib-c99.patch

to the appropriate file in the port allows t1lib to compile and build correctly under Xcode 15, and no other modifications appeared to be necessary.

I'm not entirely sure how to submit a correction to the port the right way, despite spending some time trying to read through the docs. Since its such a simple diff, I hope that it is easy for a maintainer to fix up.

comment:4 Changed 7 days ago by ryandesign (Ryan Carsten Schmidt)

More than just that one patch should be applied. Compiling successfully does not guarantee the program works correctly. There are C99 compatibility problems in the configure script as well, for example, some of which are solved by another rawhide patch in that same directory and some of which are not fixed by any of their patches. This means some of the configure script's results do not actually reflect the features they were intended to test.

Note: See TracTickets for help on using tickets.