Opened 7 months ago

Closed 6 months ago

#69882 closed defect (fixed)

rnnoise @0.2: Depends on wget and downloads a file at build time

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jasonliu-- (Jason Liu)
Priority: Normal Milestone:
Component: ports Version: 2.9.3
Keywords: haspatch Cc:
Port: rnnoise

Description

rnnoise @0.2 downloads ​https://media.xiph.org/rnnoise/models/rnnoise_data-0b50c45.tar.gz at build time using wget. Instead, this should be listed as a distfile.

Change History (2)

comment:1 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

And this is only happening because rnnoise downloads an automatically-generated tarball from GitHub, which does not contain the data, so the data file needs to be fetched separately. But rnnoise offers a release download that already contains everything. Release downloads should be used when available.

​https://github.com/macports/macports-ports/pull/23775

comment:2 Changed 6 months ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: assigned → closed

In 16135ad44f04ea64fb45f93471a4ac5856a1a8b6/macports-ports (master):

rnnoise: Use release tarball

Removes the need to autoreconf. Removes need for autoconf, automake,
libtool, wget dependencies. No longer downloads a file at build time.
The version number is now correct in rnnoise.pc.

Closes: #69882

Note: See TracTickets for help on using tickets.