mpv @0.38.0: error: expected ',' separator

[mrkapqa]

hello ,

got this error on newer installation of macos bigsur

--->  Attempting to fetch mpv-0.38.0_0+audiocd+bluray+bundle+dvd+libarchive+network+opengl+osd+python312+rubberband.darwin_20.x86_64.tbz2 from https://mse.uk.packages.macports.org/mpv
--->  Fetching distfiles for mpv
--->  Verifying checksums for mpv
--->  Extracting mpv
--->  Applying patches to mpv
--->  Configuring mpv
--->  Building mpv                                       
Error: Failed to build mpv: command execution failed     
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_multimedia_mpv/mpv/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port mpv failed

Thank you very much.

[ryandesign (Ryan Carsten Schmidt)]

We see errors building this port on the macOS 12 buildbot worker too. Maybe mpv now requires a newer version of Swift than the versions of Xcode on macOS 12 and earlier have.

[Gandoon (Erik Hedlund)]

Replying to ryandesign:

We see errors building this port on the macOS 12 buildbot worker too. Maybe mpv now requires a newer version of Swift than the versions of Xcode on macOS 12 and earlier have.

Just a little note:

I have tried to build the MacPorts version of mpv on MacOS 10.15 and have also run into problems building it, including the any keyword issue. I built a working version 0.38 directly from the GitHub master repository. The Swift issue seems to be solved there. I mainly had issues with video/out/opengl/egl_helpers.h and Lua, so I had to explicitly point to the correct (<= 5.2) version by changing the includes in the source code for $SOURCE_ROOT/player/lua.c to point directly to e.g. "/opt/local/include/lua5.2/lua[lib].h. This may be necessary if you have multiple Lua:s installed. Also, a good idea is to explicitly disable the touchbar functionality if you don't have one: -Dmacos-touchbar=disable.

There also seems to be a few tweaks to the code removing bits that were trying to include non-existent EGL headers despite EGL features being disabled, something that was the main problem I ran into with the (MacPorts) release version of the code. Maybe this is mainly an issue on older systems. I could not tell as I do not currently have a modern system to test on.

Just as a test, I transplanted the entirety of the latest snapshot of the git repository that I had successfully built with the above additions. I performed a port -v extract mpv [+options here], edited the portfile to include -Dmacos-touchbar=disable, and then copied the whole repository to the MacPorts work directory. Then I performed in sequence port -v configure mpv [+options here], checking if all sensible options actually were correctly flagged, and then a port -v build mpv [+options here]. With the transplanted repository, all my problems with my configuration: mpv @0.38.0_0+audiocd+bluray+bundle+caca+dvd+jack+libarchive+libmpv+opengl+osd+python312+rubberband+screenshot+uchardet+vapoursynth+vulkan+ytdlp went away and I now also have a working MacPorts installation, albeit somewhat tweaked ;)