Opened 6 months ago

Closed 4 months ago

Last modified 4 months ago

#70017 closed enhancement (fixed)

Check config.log for -Wimplicit-int and -Wincompatible-function-pointer-types

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: Ryan Carsten Schmidt <git@…>
Priority: Normal Milestone: MacPorts 2.10.0
Component: base Version:
Keywords: haspatch Cc:
Port:

Description

MacPorts base contains code that checks config.log files for instances of implicit function declarations because new clang versions default to -Werror=implicit-function-declaration and this can cause available features not to be found:

https://github.com/macports/macports-base/blob/4dfabb9c0de9abfcbb4acf1ad68471b0a20983ab/src/port1.0/portconfigure.tcl#L1910-L1955

Even newer clang versions default to -Werror=implicit-int and -Werror=incompatible-function-pointer-types. Shall MacPorts base be enhanced to check for and warn about these too? I just encountered a port (php74) that failed to build due to an incorrect configure decision resulting from implicit int.

Change History (4)

comment:1 Changed 6 months ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

comment:2 Changed 4 months ago by Ryan Carsten Schmidt <git@…>

Owner: set to Ryan Carsten Schmidt <git@…>
Resolution: fixed
Status: newclosed

In cfacb20bde7f9073e388f7368bdf77c65be5e2b2/macports-base (master):

Check for more warnings in configure logs

Check for -Wimplicit-int and -Wincompatible-function-pointer-types
warnings in configure logs because llvm.org clang 16 and the latest
Apple clang consider those to be errors.

Closes: #70017

comment:3 Changed 4 months ago by jmroot (Joshua Root)

Milestone: MacPorts Future

comment:4 Changed 4 months ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 2.10.0
Note: See TracTickets for help on using tickets.