UPDATE: FLAC 1.1.2

[namely_void@…]

Flac 1.1.2 make system is really broken and it's a wonder that it currently builds at all. Update auto/makefiles with stuff from ubuntu. Also update one manual page while on it. Additionally, flac doesn't require id3lib and doesn't even use it anymore, but does require libiconv.

[namely_void@…]

This is still a valid UPDATE, even after some changes seem to have gone into the repository. The old maintainer seems to have abandonded this port(?)

[takanori@…]

Flac 1.1.2 make system is really broken

Could you explain it a little?

Anyway, patch-flac-1.1.2-1ubuntu2-makesys is too large to put into dports/ tree. Why don't you use automake instead?

patch-flac-1.1.2-1ubuntu2-man

I couldn't understand why this patch is needed. The content is same, isn't it?

flac doesn't require id3lib and doesn't even use it anymore, but does require libiconv.

I agree. You're right.

[takanori@…]

Portfile.diff

[namely_void@…]

Yamamoto-san,

(In reply to comment #3)

Flac 1.1.2 make system is really broken

Could you explain it a little?

Well, if you look at the build log you'll see what I'm talking about. Libtool gives loads of errors running the script. (I'm on 10.4. btw.) The gist of the problem is that the automake/conf scripts are built using an ancient (broken) version of autotools.

Anyway, patch-flac-1.1.2-1ubuntu2-makesys is too large to put into dports/ tree. Why don't you use automake instead?

I kind of figured this out. Can dports use bzipped patches? The problem with automake/conf is that Apple's packaged version is quite useless and I don't want a dependency on dports automake/conf. See below for more ranting on this.

patch-flac-1.1.2-1ubuntu2-man

I couldn't understand why this patch is needed. The content is same, isn't it?

Hmmh.. Too bad I didn't make a note to myself, but I'd remember that there were some syntax errors there or something. I suppose it can be dropped, if there's no build or use (man ...) errors on the mac.

flac doesn't require id3lib and doesn't even use it anymore, but does require libiconv.

I agree. You're right.

(In reply to comment #4)

Created an attachment (id=7776) [edit] Portfile.diff

Here is an experimental patch I wrote.

Although dports guidelines might imply to that direction, I'd rather not build xmms plugin as a default, because it's not really an independent functionality of this package, but an extension to xmms, IOW if I have/want xmms, I probably want this xmms-plugin, but if I want flac, I presumably don't want xmms.

I also wouldn't like to depend on dports automake/autoconf. Rebuilding the automake/conf stuff also requires xmms, which is starting to add loads of excess bloat if I just want to install the flac library. Now, I know the completely rebuilt automake system patch isn't the cleanest possible solution, but if it's good enough for Debian people, it should be good enough for dports.

[markd@…]

Updated to 1.1.3 in #11355.