crystfel fails to build and should be updated

[barracuda156]

Post fails to build both with Xcode gcc and gcc-13.

hdf5-file.h:67: error: expected ')' before 'fh'
hdf5-file.h:96: error: expected declaration specifiers or '...' before 'hid_t'

libtool: compile:  /opt/local/bin/gcc-mp-13 -DHAVE_CONFIG_H -I. -I.. -DDATADIR=\"/opt/local/share\" -I../lib -Wall -I../lib -pipe -Os -arch ppc -I/opt/local/include -pipe -Os -arch ppc -MT src/cell.lo -MD -MP -MF src/.deps/cell.Tpo -c src/cell.c  -fno-common -DPIC -o src/.libs/cell.o
In file included from src/detector.h:50,
                 from src/image.h:50,
                 from src/detector.c:43:
src/hdf5-file.h:67:33: error: unknown type name 'hid_t'; did you mean 'gid_t'?
   67 | extern int check_path_existence(hid_t fh, const char *path);
      |                                 ^~~~~
      |                                 gid_t
In file included from src/detector.h:50,
                 from src/image.h:50,
                 from src/image.c:36:
src/hdf5-file.h:67:33: error: unknown type name 'hid_t'; did you mean 'gid_t'?
   67 | extern int check_path_existence(hid_t fh, const char *path);
      |                                 ^~~~~
      |                                 gid_t
src/hdf5-file.h:96:58: error: unknown type name 'hid_t'; did you mean 'gid_t'?
   96 |                             struct event *ev, void *val, hid_t memtype);
      |                                                          ^~~~~
      |                                                          gid_t
src/hdf5-file.h:96:58: error: unknown type name 'hid_t'; did you mean 'gid_t'?
   96 |                             struct event *ev, void *val, hid_t memtype);
      |                                                          ^~~~~
      |                                                          gid_t
In file included from src/detector.h:50,
                 from src/image.h:50,
                 from src/utils.c:47:
src/hdf5-file.h:67:33: error: unknown type name 'hid_t'; did you mean 'id_t'?
   67 | extern int check_path_existence(hid_t fh, const char *path);
      |                                 ^~~~~
      |                                 id_t
src/hdf5-file.h:96:58: error: unknown type name 'hid_t'; did you mean 'id_t'?
   96 |                             struct event *ev, void *val, hid_t memtype);
      |                                                          ^~~~~
      |                                                          id_t
src/detector.c: In function 'fill_in_values':
src/detector.c:590:29: warning: implicit declaration of function 'hdfile_get_value'; did you mean 'hdfile_set_image'? [-Wimplicit-function-declaration]
  590 |                         r = hdfile_get_value(f, p->clen_from, ev, &val,
      |                             ^~~~~~~~~~~~~~~~
      |                             hdfile_set_image
make[2]: *** [src/image.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
src/detector.c:591:46: error: 'H5T_NATIVE_DOUBLE' undeclared (first use in this function)
  591 |                                              H5T_NATIVE_DOUBLE);
      |                                              ^~~~~~~~~~~~~~~~~
src/detector.c:591:46: note: each undeclared identifier is reported only once for each function it appears in
In file included from src/detector.h:50,
                 from src/image.h:50,
                 from src/cell.c:47:
src/hdf5-file.h:67:33: error: unknown type name 'hid_t'; did you mean 'gid_t'?
   67 | extern int check_path_existence(hid_t fh, const char *path);
      |                                 ^~~~~
      |                                 gid_t
make[2]: *** [src/utils.lo] Error 1
src/hdf5-file.h:96:58: error: unknown type name 'hid_t'; did you mean 'gid_t'?
   96 |                             struct event *ev, void *val, hid_t memtype);
      |                                                          ^~~~~
      |                                                          gid_t
make[2]: *** [src/cell.lo] Error 1
make[2]: *** [src/detector.lo] Error 1

It is also horribly out-of-date.

[ryandesign (Ryan Carsten Schmidt)]

Replying to barracuda156:

hdf5-file.h:67: error: expected ')' before 'fh'
hdf5-file.h:96: error: expected declaration specifiers or '...' before 'hid_t'

#65103

It is also horribly out-of-date.

#54608