Opened 5 months ago
Closed 5 months ago
#70141 closed defect (fixed)
nghttp2: Remove use_autoreconf yes
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | Schamschula (Marius Schamschula) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.9.3 |
| Keywords: | haspatch | Cc: | |
| Port: | nghttp2 |
Description
Does nghttp2 still need use_autoreconf yes? It was added in 2019 along with a configure.ac patch to resolve #58287. The configure.ac patch was removed in 2021 but use_autoreconf yes wasn't. The port currently doesn't patch configure.ac or any .m4 files so unless there were other reasons for autoreconfing (there is no comment in the Portfile justifying its continued existence) I suggest removing it and will submit a PR for that. It builds fine for me on macOS 12 without it.
Change History (2)
comment:1 Changed 5 months ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|
comment:2 Changed 5 months ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
https://github.com/macports/macports-ports/pull/24273