Opened 4 months ago

Closed 3 months ago

#70148 closed defect (fixed)

shairport-sync broken by a recent update

Reported by: barracuda156 Owned by: ale275 (Alessandro Gritti)
Priority: Normal Milestone:
Component: ports Version: 2.9.3
Keywords: mountainlion, lion, snowleopard, leopard, tiger Cc: mohd-akram (Mohamed Akram)
Port: shairport-sync

Description

https://build.macports.org/builders/ports-10.8_x86_64-builder/builds/180717/steps/install-port/logs/stdio

	/usr/bin/gcc-4.2 -std=gnu99 -DHAVE_CONFIG_H -I.   -I/opt/local/include -Wno-multichar -Wall -Wextra -Wno-deprecated-declarations -pthread -DSYSCONFDIR=\"/opt/local/etc/shairport-sync\" -DPIDDIR=\"/opt/local/var\" -I/opt/local/include/ossp -I/opt/local/libexec/ffmpeg6/include -I/opt/local/libexec/ffmpeg6/include -I/opt/local/libexec/ffmpeg6/include -I/opt/local/libexec/ffmpeg6/include     -I/opt/local/libexec/openssl3/include   -pipe -Os -arch ppc -MT player.o -MD -MP -MF $depbase.Tpo -c -o player.o player.c &&\
	mv -f $depbase.Tpo $depbase.Po
In file included from shairport.c:34:
/usr/include/net/if.h:264: error: field ‘ifru_addr’ has incomplete type
/usr/include/net/if.h:265: error: field ‘ifru_dstaddr’ has incomplete type
/usr/include/net/if.h:266: error: field ‘ifru_broadaddr’ has incomplete type
/usr/include/net/if.h:305: error: field ‘ifra_addr’ has incomplete type
/usr/include/net/if.h:306: error: field ‘ifra_broadaddr’ has incomplete type
/usr/include/net/if.h:307: error: field ‘ifra_mask’ has incomplete type
/usr/include/net/if.h:379: error: field ‘addr’ has incomplete type
/usr/include/net/if.h:380: error: field ‘dstaddr’ has incomplete type
In file included from player.h:25,
                 from rtp.h:6,
                 from rtp.c:28:
/opt/local/include/plist/plist.h:74: warning: ignoring #pragma message 
In file included from player.h:25,
                 from mdns.h:5,
                 from mdns.c:28:
/opt/local/include/plist/plist.h:74: warning: ignoring #pragma message 
In file included from player.h:25,
                 from mdns.h:5,
                 from common.h:19,
                 from common.c:29:
/opt/local/include/plist/plist.h:74: warning: ignoring #pragma message 
In file included from /opt/local/include/libavutil/avutil.h:296,
                 from /opt/local/include/libavutil/samplefmt.h:24,
                 from /opt/local/include/libavcodec/avcodec.h:31,
                 from rtp.c:49:
/opt/local/include/libavutil/common.h: In function ‘av_sat_add64_c’:
/opt/local/include/libavutil/common.h:380: warning: suggest parentheses around arithmetic in operand of |
In file included from /opt/local/include/libavutil/avutil.h:296,
                 from /opt/local/include/libavutil/samplefmt.h:24,
                 from /opt/local/include/libavcodec/avcodec.h:31,
                 from shairport.c:49:
/opt/local/include/libavutil/common.h: In function ‘av_sat_add64_c’:
/opt/local/include/libavutil/common.h:380: warning: suggest parentheses around arithmetic in operand of |
depbase=`echo alac.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
	/usr/bin/gcc-4.2 -std=gnu99 -DHAVE_CONFIG_H -I.   -I/opt/local/include -Wno-multichar -Wall -Wextra -Wno-deprecated-declarations -pthread -DSYSCONFDIR=\"/opt/local/etc/shairport-sync\" -DPIDDIR=\"/opt/local/var\" -I/opt/local/include/ossp -I/opt/local/libexec/ffmpeg6/include -I/opt/local/libexec/ffmpeg6/include -I/opt/local/libexec/ffmpeg6/include -I/opt/local/libexec/ffmpeg6/include     -I/opt/local/libexec/openssl3/include   -pipe -Os -arch ppc -MT alac.o -MD -MP -MF $depbase.Tpo -c -o alac.o alac.c &&\
	mv -f $depbase.Tpo $depbase.Po
In file included from player.h:25,
                 from mdns.h:5,
                 from common.h:19,
                 from rtsp.c:70:
/opt/local/include/plist/plist.h:74: warning: ignoring #pragma message 
In file included from player.h:25,
                 from mdns.h:5,
                 from common.h:19,
                 from player.c:83:
/opt/local/include/plist/plist.h:74: warning: ignoring #pragma message 
rtsp.c: In function ‘rtsp_listen_loop’:
rtsp.c:5672: error: ‘TCP_KEEPCNT’ undeclared (first use in this function)
rtsp.c:5672: error: (Each undeclared identifier is reported only once
rtsp.c:5672: error: for each function it appears in.)
rtsp.c:5676: error: ‘TCP_KEEPINTVL’ undeclared (first use in this function)
make[1]: *** [rtsp.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from player.h:25,
                 from mdns.h:5,
                 from common.h:19,
                 from shairport.c:74:
/opt/local/include/plist/plist.h: At top level:
/opt/local/include/plist/plist.h:74: warning: ignoring #pragma message 
make[1]: *** [shairport.o] Error 1
common.c: In function ‘do_sps_log_to_fd’:
common.c:236: warning: implicit declaration of function ‘dprintf’
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_multimedia_shairport-sync/shairport-sync/work/shairport-sync-4.3.3'
make: *** [all] Error 2

Change History (4)

comment:1 in reply to:  description ; Changed 4 months ago by ryandesign (Ryan Carsten Schmidt)

Replying to barracuda156:

/usr/include/net/if.h:264: error: field ‘ifru_addr’ has incomplete type
/usr/include/net/if.h:265: error: field ‘ifru_dstaddr’ has incomplete type
/usr/include/net/if.h:266: error: field ‘ifru_broadaddr’ has incomplete type
/usr/include/net/if.h:305: error: field ‘ifra_addr’ has incomplete type
/usr/include/net/if.h:306: error: field ‘ifra_broadaddr’ has incomplete type
/usr/include/net/if.h:307: error: field ‘ifra_mask’ has incomplete type
/usr/include/net/if.h:379: error: field ‘addr’ has incomplete type
/usr/include/net/if.h:380: error: field ‘dstaddr’ has incomplete type

Maybe similar to #59713? Try including those extra headers before including <net/if.h>. Possibly broken by https://github.com/mikebrady/shairport-sync/commit/ccc4fe09af507a0a4597f7b4e88b858dff5843ff#diff-dcedc9bdc41584e66270992c54b80011e0324bd2a77bff35b36510115f6ca88a. Possibly previously fixed by https://github.com/mikebrady/shairport-sync/commit/8a6eb02d59f56b0f03f7dcf3626d96789c1f0671.

comment:2 in reply to:  1 Changed 4 months ago by barracuda156

Replying to ryandesign:

Yes, you are right, they have broken again what was fixed earlier, but then the build fails on:

rtsp.c: In function ‘rtsp_listen_loop’:
rtsp.c:5672: error: ‘TCP_KEEPCNT’ undeclared (first use in this function)
rtsp.c:5672: error: (Each undeclared identifier is reported only once
rtsp.c:5672: error: for each function it appears in.)
rtsp.c:5676: error: ‘TCP_KEEPINTVL’ undeclared (first use in this function)
make[1]: *** [rtsp.o] Error 1

We had tickets mentioning these, but nothing useful: #69634 #64941

Last edited 4 months ago by barracuda156 (previous) (diff)

comment:4 Changed 3 months ago by barracuda156

Resolution: fixed
Status: assignedclosed

In 5fe3ba67853eed844655cda80e78a548bc77ff37/macports-ports (master):

shairport-sync: fix for older systems

Closes: #70148

Note: See TracTickets for help on using tickets.