hdfeos @3.0: configure: error: szlib is not functional

[cooljeanius (Eric Gallager)]

When attempting to upgrade h4h5tools, dependency hdfeos fails to configure, saying:

checking szlib.h usability... yes
checking szlib.h presence... yes
checking for szlib.h... yes
checking for SZ_BufftoBuffCompress in -lsz... yes
checking if szlib is functional... configure: error: szlib is not functional
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_hdfeos/hdfeos/work/hdf-eos2-3.0" && ./configure --prefix=/opt/local --with-hdf4=/opt/local --with-jpeg=/opt/local --with-zlib=/opt/local --enable-shared --disable-dependency-tracking --with-szlib=/opt/local 
Exit code: 1
Error: Failed to configure hdfeos: consult /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_hdfeos/hdfeos/work/hdf-eos2-3.0/config.log
Error: Failed to configure hdfeos: configure failure: command execution failed
DEBUG: Error code: NONE
DEBUG: Backtrace: configure failure: command execution failed
    while executing
"$procedure $targetname"
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_hdfeos/hdfeos/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

"szlib" is supposed to come from the szip port, however, that's properly installed, so it ought to be functional:

$ port installed szip
The following ports are currently installed:
  szip @2.1.1_0+encoder (active)

I'll attach logs next.

[cooljeanius (Eric Gallager)]

main.log for hdfeos

[cooljeanius (Eric Gallager)]

config.log for hdfeos

[cooljeanius (Eric Gallager)]

...ah, from looking at config.log, it looks like this is another instance of -Werror=implicit-function-declaration being on by default now:

configure:17710: checking if szlib is functional
configure:17731: /opt/local/bin/h4cc -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 -I/opt/local/include -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -DSIZEOF_LONG=8 -L/opt/local/lib -L/opt/local -L/opt/local -L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk -arch x86_64 conftest.c -lsz -lz -ljpeg -lm  >&5
clang: warning: -Wl,-headerpad_max_install_names: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local/lib' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-L/opt/local/lib' [-Wunused-command-line-argument]
conftest.c:36:21: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
                    exit(0);
                    ^
conftest.c:36:21: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
1 error generated.
configure:17731: $? = 1
configure: program exited with status 1

[ryandesign (Ryan Carsten Schmidt)]

It should be reported to the developers, however their web presence is such a disaster that I would not be able to suggest to you how to do that.

[ryandesign (Ryan Carsten Schmidt)]

​https://github.com/macports/macports-ports/pull/24549

[ryandesign (Ryan Carsten Schmidt)]

In 03d40458904165414a4ab40b3a32b9daeacfc682/macports-ports (master):

hdfeos: Fix implicit function declaration

Closes: #70234