Opened 3 months ago

Closed 3 months ago

#70464 closed defect (fixed)

claws-mail, nmap, and ncarg have bad OS version conditionals

Reported by: fhgwright (Fred Wright) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.9.3
Keywords: Cc: ghosthound, danielluke (Daniel J. Luke), tenomoto (Takeshi Enomoto)
Port: claws-mail, nmap, ncarg

Description

I stumbled across this: 

MacPro:macports-ports fw$ git grep -n '${os.version} *[<>=]'
mail/claws-mail/Portfile:58:if {${os.platform} eq "darwin" && ${os.version} < 12} {
net/nmap/Portfile:58:if {${os.platform} eq "darwin" && ${os.version} < 13} {
science/ncarg/Portfile:171:        if {${os.version}>=12} {

In each case, ${os.version} should almost certainly be ${os.major}. As it is, 10.4 and 10.5 (darwin 8 and 9) are treated as the most recent systems.

Change History (4)

comment:1 Changed 3 months ago by jmroot (Joshua Root)

In f3fbbb818abcd77bb1199839f0db20afb86fd1ef/macports-ports (master):

claws-mail: fix OS version comparison

os.version has to be compared using vercmp.

See: #70464

comment:2 Changed 3 months ago by ryandesign (Ryan Carsten Schmidt)

In 4e2b9d1ba344ea380d9fdc879f4b27957df069ee/macports-ports (master):

ncarg: Fix Mountain Lion version comparison

See: #70464

comment:3 Changed 3 months ago by danielluke (Daniel J. Luke)

In f9cc4c1821d72f5da97e6d20c019db78c5d4a9f2/macports-ports (master):

nmap: fix version comparison

See: #70464

comment:4 Changed 3 months ago by jmroot (Joshua Root)

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.