libarchive @3.7.6 does not build on PPC Tiger, Mac OS X 10.4.11, because old patches need updates

[ballapete (Peter "Pete" Dyballa)]

--->  Applying patches to libarchive
--->  Applying fix_pc_file.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/libarchive-3.7.6" && /usr/bin/patch -t -N -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/tarballs/ports/archivers/libarchive/files/fix_pc_file.patch'
patching file build/pkgconfig/libarchive.pc.in
--->  Applying patch-libarchive-3.5-fix-tests-tiger.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/libarchive-3.7.6" && /usr/bin/patch -t -N -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/tarballs/ports/archivers/libarchive/files/patch-libarchive-3.5-fix-tests-tiger.diff'
patching file libarchive/test/test_entry.c
Hunk #1 succeeded at 426 (offset -1 lines).
patching file tar/test/test_option_acls.c
Hunk #1 succeeded at 43 (offset -1 lines).
--->  Applying STAILQ_FOREACH.patch
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/libarchive-3.7.6" && /usr/bin/patch -t -N -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/tarballs/ports/archivers/libarchive/files/STAILQ_FOREACH.patch'
patching file unzip/bsdunzip.c
Hunk #1 FAILED at 40.
1 out of 1 hunk FAILED -- saving rejects to file unzip/bsdunzip.c.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/libarchive-3.7.6" && /usr/bin/patch -t -N -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/tarballs/ports/archivers/libarchive/files/STAILQ_FOREACH.patch'

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Tiger, Mac OS X 10.4.11

[ballapete (Peter "Pete" Dyballa)]

Here is an updated version of patch-libarchive-3.5-fix-tests-tiger.diff as patch-libarchive-3.7-fix-tests-tiger.diff.

[ballapete (Peter "Pete" Dyballa)]

Updated patch file for C source files libarchive/test/test_entry.c and tar/test/test_option_acls.c

[ballapete (Peter "Pete" Dyballa)]

The additional C code for test target seems to compile fine without STAILQ_FOREACH.patch for bsdunzip_test (I do not know what happened with earlier version of libarchive). Nevertheless it ends with

libtool: link: /opt/local/bin/gcc-apple-4.2 -std=gnu99 -pipe -Os -arch ppc -Wall -Wformat -Wformat-security -fvisibility=hidden -D__LIBARCHIVE_ENABLE_VISIBILITY -Wl,-headerpad_max_install_names -arch ppc -o bsdunzip_test test_utils/bsdunzip_test-test_utils.o test_utils/bsdunzip_test-test_main.o unzip/test/bsdunzip_test-test_0.o unzip/test/bsdunzip_test-test_basic.o unzip/test/bsdunzip_test-test_doubledash.o unzip/test/bsdunzip_test-test_glob.o unzip/test/bsdunzip_test-test_not_exist.o unzip/test/bsdunzip_test-test_singlefile.o unzip/test/bsdunzip_test-test_C.o unzip/test/bsdunzip_test-test_p.o unzip/test/bsdunzip_test-test_d.o unzip/test/bsdunzip_test-test_j.o unzip/test/bsdunzip_test-test_L.o unzip/test/bsdunzip_test-test_n.o unzip/test/bsdunzip_test-test_o.o unzip/test/bsdunzip_test-test_q.o unzip/test/bsdunzip_test-test_t.o unzip/test/bsdunzip_test-test_t_bad.o unzip/test/bsdunzip_test-test_version.o unzip/test/bsdunzip_test-test_x.o unzip/test/bsdunzip_test-test_Z1.o unzip/test/bsdunzip_test-test_P_encryption.o unzip/test/bsdunzip_test-test_I.o  -L/opt/local/lib ./.libs/libarchive_fe.a /opt/local/lib/liblzo2.dylib /opt/local/lib/liblzma.dylib -lzstd -llz4 /opt/local/lib/libb2.dylib -lbz2 -lz /opt/local/lib/libxml2.dylib -pthread
/usr/bin/make  check-TESTS
./build/autoconf/test-driver: line 112: 19820 Segmentation fault      "$@" >>"$log_file" 2>&1
FAIL: libarchive_test
./build/autoconf/test-driver: line 112: 19862 Segmentation fault      "$@" >>"$log_file" 2>&1
FAIL: bsdtar_test
PASS: bsdcpio_test
PASS: bsdcat_test
FAIL: bsdunzip_test

I'll try to attach all useful log files from failed tests.

[ballapete (Peter "Pete" Dyballa)]

libarchive 3.7.6: ./test-suite.log

[ballapete (Peter "Pete" Dyballa)]

FAIL: libarchive_test

[ballapete (Peter "Pete" Dyballa)]

FAIL: bsdtar_test

[ballapete (Peter "Pete" Dyballa)]

FAIL: bsdunzip_test

[ballapete (Peter "Pete" Dyballa)]

Contents of /opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/.tmp/bsdtar_test.2024-09-26T14.40.35-000 directory

[ballapete (Peter "Pete" Dyballa)]

Contents of /opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/.tmp/bsdunzip_test.2024-09-26T14.41.44-00 directory

[ballapete (Peter "Pete" Dyballa)]

Contents of /opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/.tmp/libarchive_test.2024-09-26T14.40.34-00

[tobypeterson]

The attached patch-libarchive-3.5-fix-tests-tiger.diff is unchanged. The real issue appears to be STAILQ_FOREACH.patch, which is no longer needed, as far as I can tell: ​https://github.com/libarchive/libarchive/pull/2222

[tobypeterson]

Can you remove STAILQ_FOREACH.patch from the patchfiles and try again? If that works, I'll push a change to remove the patch.

[ballapete (Peter "Pete" Dyballa)]

Replying to tobypeterson:

The attached patch-libarchive-3.5-fix-tests-tiger.diff is unchanged.

Line numbers are adjusted.

[ballapete (Peter "Pete" Dyballa)]

Replying to tobypeterson:

Can you remove STAILQ_FOREACH.patch from the patchfiles and try again? If that works, I'll push a change to remove the patch.

libarchive @3.7.6_0 (active) requested_variants='' platform='darwin 8' archs='ppc' date='2024-09-26T16:13:41+0200'

[tobypeterson]

Line numbers don't really matter, as long as there's no fuzzing required.

[tobypeterson]

In 28b7f1907f448440c6c3163fdf5dc869c0579598/macports-ports (master):

libarchive: remove unnecessary/broken patch

fixes #70936