Opened 7 weeks ago

#70963 assigned defect

ashuffle uses bundled abseil which is old and broken

Reported by: barracuda156 Owned by: l2dy (Zero King)
Priority: Normal Milestone:
Component: ports Version: 2.10.1
Keywords: Cc:
Port: ashuffle

Description

Why does it need a bundled abseil? I think we fixed this bug ages ago, but of course a bundled copy is unfixed:

--->  Building ashuffle
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_ashuffle/ashuffle/work/build" && /opt/local/bin/ninja -j6 -v 
[1/61] ccache /opt/local/bin/g++-mp-14 -Isubprojects/absl/libabsl_base.a.p -Isubprojects/absl -I../ashuffle-3.13.3/subprojects/absl -Isubprojects/absl/__CMake_build -I../ashuffle-3.13.3/subprojects/absl/__CMake_build -I/opt/local/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -Wall -Winvalid-pch -Wextra -std=gnu++17 -O0 -g -Werror=switch -fno-omit-frame-pointer -pipe -Os -arch ppc -Os -D_GLIBCXX_USE_CXX11_ABI=0 -arch ppc -g -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Wcast-qual -Wconversion-null -Wformat-security -Wmissing-declarations -Woverlength-strings -Wpointer-arith -Wundef -Wunused-local-typedefs -Wunused-result -Wvarargs -Wvla -Wwrite-strings -DNOMINMAX -MD -MQ subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o -MF subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o.d -o subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o -c ../ashuffle-3.13.3/subprojects/absl/absl/base/internal/unscaledcycleclock.cc
FAILED: subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o 
ccache /opt/local/bin/g++-mp-14 -Isubprojects/absl/libabsl_base.a.p -Isubprojects/absl -I../ashuffle-3.13.3/subprojects/absl -Isubprojects/absl/__CMake_build -I../ashuffle-3.13.3/subprojects/absl/__CMake_build -I/opt/local/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -Wall -Winvalid-pch -Wextra -std=gnu++17 -O0 -g -Werror=switch -fno-omit-frame-pointer -pipe -Os -arch ppc -Os -D_GLIBCXX_USE_CXX11_ABI=0 -arch ppc -g -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Wcast-qual -Wconversion-null -Wformat-security -Wmissing-declarations -Woverlength-strings -Wpointer-arith -Wundef -Wunused-local-typedefs -Wunused-result -Wvarargs -Wvla -Wwrite-strings -DNOMINMAX -MD -MQ subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o -MF subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o.d -o subprojects/absl/libabsl_base.a.p/absl_base_internal_unscaledcycleclock.cc.o -c ../ashuffle-3.13.3/subprojects/absl/absl/base/internal/unscaledcycleclock.cc
../ashuffle-3.13.3/subprojects/absl/absl/base/internal/unscaledcycleclock.cc:104:2: error: #error Must implement UnscaledCycleClock::Frequency()
  104 | #error Must implement UnscaledCycleClock::Frequency()
      |  ^~~~~
../ashuffle-3.13.3/subprojects/absl/absl/base/internal/unscaledcycleclock.cc: In static member function 'static double absl::lts_20211102::base_internal::UnscaledCycleClock::Frequency()':
../ashuffle-3.13.3/subprojects/absl/absl/base/internal/unscaledcycleclock.cc:106:1: warning: no return statement in function returning non-void [-Wreturn-type]
  106 | }
      | ^

Of course, patches could be backported, by perhaps just use MacPorts abseil which builds fine?

Change History (0)

Note: See TracTickets for help on using tickets.