Opened 19 years ago
Closed 19 years ago
#8034 closed defect (fixed)
UPDATE: srecord 1.24
| Reported by: | aconchillo@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.2 |
| Keywords: | Cc: | ||
| Port: |
Description
New upstream release.
Attachments (1)
Change History (4)
Changed 19 years ago by aconchillo@…
| Attachment: | srecord-1.24.patch added |
|---|
comment:1 Changed 19 years ago by blb@…
Looks like you want to leave in the destroot reference on the mandir option (and possibly infodir) as otherwise, it tries to install directly into ${prefix} which means DarwinPorts won't see it and record it.
comment:2 Changed 19 years ago by aconchillo@…
I don't really know which is the best way to do it. I've looked at other packages but I don't how to do it. I've installed the port and I can man the manpages.
Which is the right way?
comment:3 Changed 19 years ago by blb@…
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In reply to comment #3)
I don't really know which is the best way to do it. I've looked at other packages but I don't how to do it. I've installed the port and I can man the manpages.
Yup, it does install the man pages, but it installs them directly to the DP install location, not the destroot. If you then run 'port contents srecord' it shouldn't show those man pages, since skipping the destroot, port doesn't see them and can't add them to the list of files installed. This will then keep them from being uninstalled if you do that later.
The way the Portfile does it now, with "--mandir=${destroot}${prefix}/share/man" forces it to install into the destroot, which makes sure they are visible for port when it looks at what files are involved. Unfortunately, some packages do this (eg, advancescan, slib, ghc, and many others), so we have to play these kinds of games to keep things working fine...
Which is the right way?
The only change your patch needs is to leave the mandir bit (with the ${destroot}) as is, and all should work fine. In fact, the infodir option can be removed since it doesn't appear to install any info files. Since that's all there is to it, I've gone ahead and committed your patch with the mandir/infodir fixes mentioned.
srecord 1.24