BUG : startupitem.pidfile is messy

[yves@…]

the "cleanup" option is called "clean" in the code and produced this stop code :

sh /opt/local/etc/startup/gnustep-base.sh

but no such file is created

good idea though

[jberry@…]

Yves: can you be more specific about what you're doing, what you expect, and what you get? Thx.

[yves@…]

I write in the Portfile

startupitem.pidfile cleanup

I get

Error: ---> Unknown pidfile style cleanup presented to startupitem.pidfile

So I looked at portstartuitem.tcl and found that the code uses "clean" for the cleanup switch, so I replaced them with "cleanup". The process seemed to work, but looking at the wrapper I found :

Stop() {

sh /opt/local/etc/startup/gnustep-base.sh stop

}

But there was no destroot/opt/local/etc/startup/gnustep-base.sh

I would also expect seeing gdomap.sh since that is the name of the startup item (gnustep-base is the name of the port)

[jberry@…]

Could you please attach the Portfile you're working on? And is this on 10.4 with launchd startup items enabled?

[yves@…]

gnustep-base Portfile

[jberry@…]

Yves,

The code that you see generated for Stop(), is being generated because this is the default for when you specify no stop startupitem.stop. If you supply start code, you should probably be supplying stop code as well, to stop the process.

The only time in which start/stop code is not needed is (a) if the defaults suffice (not very likely) or (b) if you use startupitem.executable to name the executable, and let the code completely handle starting/stopping the process.

If you have more questions or comments on this, I'd be happy to take them on-list.