BUG: caches are bypassed when fetching distfiles

[josh_root@…]

A "Pragma: no-cache" header is always sent when DP fetches distfiles via HTTP. There doesn't seem to be any good reason for this to be the default behaviour, it's just wasting bandwidth.

[blb@…]

Patch to base

[jberry@…]

I know I'm dense, but, a couple of questions...

So we use curl as a client. Whether or not we send a no-cache header, it shouldn't mean much of anything (unless there's a proxy involved?) since the server presumably doesn't respond to it. So this bug reports that we should change the default's used by curl because we use a few extra bytes in request headers over the wire?

Just making sure I'm clear..

[josh_root@…]

No, I'm not worried about the header being sent per se. It's the result it causes with caching proxies, as you guessed. There's people (like me) who run Squid on their LAN, and lots of ISPs use a transparent proxy to cache HTTP traffic.

[josh_root@…]

I tested the patch and it appears to have the desired effect.

[pguyot (Paul Guyot)]

Thanks. Committed.