fs-traverse should take a list of directories

[kballard (Lily Ballard)]

Currently fs-traverse takes a dynamic number of arguments, each of which is a directory to search. Instead it should take a single argument which is a list of directories.

[kballard (Lily Ballard)]

Currently openssl​ and kernel-tools use fs-traverse. openssl just uses it to traverse one directory, so no change is needed. kernel-tools traverses 3 directories, so the Portfile would need changing, which unfortunately breaks compatibility with 1.4.3. The alternative solution is to make fs-traverse do both at the same time - a dynamic number of arguments, each which can be a list. Then when 1.4.4 (or 1.5) is released, we can change the Portfiles. The problem with this is it's unnecessarily complicated from a usage perspective. I don't really want to support a function which behaves like that. We could leave it as undocumented behaviour, and then remove it post-1.5, but that's still ugly.

Another solution might be to fix this to take the list, update kernel-tools, and shove out a 1.4.4 immediately, but that just adds to the whole "release diarrhea" issue.

[kballard (Lily Ballard)]

Aaaaand I meant to do a preview on that comment to make sure my links worked, which obviously they didn't. Oops.

[sfiera@…]

As of r24403, kernel-tools no longer depends on this behavior.

[kballard (Lily Ballard)]

Fixed in r24410

[jmpalacios (Juan Manuel Palacios)]

Merged into the release_1_4 branch in r24908.

-jmpp