BUG: Internal delete command segfaults with very long list of arguments

[jmpalacios (Juan Manuel Palacios)]

Working on the rpm Portfile I wrote a line to take care of a bunch of files we don't want in the destroot:

eval delete [glob ${destroot}${prefix}/lib/libpopt.*]

But that causes MacPorts to segfault, presumably because the expansion yields a very long list of arguments:

DEBUG: delete: /opt/local/var/macports/build/_usr_local_src_macosforge_macports_trunk_dports_sysutils_rpm/work/destroot/opt/local/lib/libpopt.0.0.0.dylib /opt/local/var/macports/build/_usr_local_src_macosforge_macports_trunk_dports_sysutils_rpm/work/destroot/opt/local/lib/libpopt.0.dylib /opt/local/var/macports/build/_usr_local_src_macosforge_macports_trunk_dports_sysutils_rpm/work/destroot/opt/local/lib/libpopt.a /opt/local/var/macports/build/_usr_local_src_macosforge_macports_trunk_dports_sysutils_rpm/work/destroot/opt/local/lib/libpopt.dylib /opt/local/var/macports/build/_usr_local_src_macosforge_macports_trunk_dports_sysutils_rpm/work/destroot/opt/local/lib/libpopt.la
Segmentation fault

Are we exhausting a buffer somewhere? Any idea how we can insert all this into gdb?

-jmpp

PS: The delete command does work in other situations, as the line prior to the offending one above demonstrates:

eval delete [glob ${destroot}${prefix}/share/man/man3/popt.3*]

Producing:

DEBUG: delete: /opt/local/var/macports/build/_usr_local_src_macosforge_macports_trunk_dports_sysutils_rpm/work/destroot/opt/local/share/man/man3/popt.3

So it's not that delete is overall broken.

[kballard (Lily Ballard)]

If you run it in gdb (which should be easy enough) once you segfault you should be able to get a backtrace and give it to me.

I'll do some experimenting on my own to see if I can reproduce it.

[kballard (Lily Ballard)]

Ok, I've reproduced it. I'll see if I can fix it now.

[kballard (Lily Ballard)]

D'oh! What a stupid mistake.

Fixed in r26397.

[jmpalacios (Juan Manuel Palacios)]

Milestone Needs developer review deleted

[tobypeterson]

Milestone MacPorts base bugs deleted