[NEW]: Shiira-2.2

[themiwi@…]

Shiira-2.2

the portfile can be found here: ATTACHED

Description: Webbrowser with unique features using Cocoa and Web Kit. Had to patch the Xcode project files for a proper install and non-universal builds. The patch files are contained in the attached tarball (files.tgz).

Homepage: ​http://shiira.jp/en.php

Comments: When activating the port the icon of the .app folder didn't show up properly. Not sure what the problem is. Trying to set a new one using iconographer as non-root resulted in an error, but the proper icon showed up...

[themiwi@…]

Portfile for Shiira-2.2

[themiwi@…]

The files directory for Shiira-2.2 containing the patches

[jmroot (Joshua Root)]

OK, I had to fix a few things, but this is now working and ready to be added. One question first though: Do you want me to add openmaintainer to the maintainers field, or do you want to be 'it'?

[themiwi@…]

Thanks. openmaintainer is fine. I currently do not have the time to do so.

[jmroot (Joshua Root)]

Added in r34415. Thanks!

[ryandesign (Ryan Carsten Schmidt)]

The port overrides the destroot phase and makes use of the cd command which will disappear in MacPorts 1.7, so it should not be used. I'm not sure the destroot phase needs to be overridden in the first place. Instead of this...

destroot	{
    cd ${worksrcpath}
	system "${build.cmd} install ${build.target}			\
		INSTALL_PATH=/Applications/MacPorts			        \
		INSTALL_MODE_FLAG=go-w,a+rX DSTROOT=${destroot}"
}

...why not something like this (untested, but something like this should work):

destroot.post_args ${build.target}
destroot.destdir INSTALL_PATH=/Applications/MacPorts INSTALL_MODE_FLAG=go-w,a+rX DSTROOT=${destroot}

Also, the exit command does not exist in MacPorts 1.6 already. And you only want to print a message if the user is actually on his way to installing something. The way this is written now, the message will also be printed if something like port info is used, which is not desired. The usual solution is to print the message in the pre-fetch phase. So instead of this...

platform darwin {
    if {${os.major} < 8} {
		ui_msg "Shiira 2 needs Mac OS X 10.4 \'Tiger\' or later."
		exit 1
	}
}

...do this:

platform darwin {
	if {${os.major} < 8} {
		pre-fetch {
			return -code error "Shiira 2 needs Mac OS X 10.4 \"Tiger\" or later."
		}
	}
}

Finally, the portfile uses a haphazard mix of spaces and tabs for indentation and alignment. You should pick just one, preferably converting all tabs to spaces. Please commit whitespace changes separately from functional changes.

[ryandesign (Ryan Carsten Schmidt)]

Hmm, this might be the better way to split up the destroot:

destroot.post_args ${build.target} INSTALL_PATH=/Applications/MacPorts INSTALL_MODE_FLAG=go-w,a+rX
destroot.destdir DSTROOT=${destroot}

[jmroot (Joshua Root)]

Thanks Ryan. I fixed the tab/space issue in r34440, and the OS version check in r34441. I'll try out the destroot a bit later.

[jmroot (Joshua Root)]

Destroot fixed in r34719. It seems that destroot.destdir doesn't make it into the destroot command for pbx builds, so I appended it to destroot.post_args.

[(none)]

Milestone Port Submissions deleted