Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#12591 closed update (fixed)

Update Portfile - pandoc 0.44

Reported by: jgm@… Owned by: boeyms@…
Priority: Normal Milestone:
Component: ports Version: 1.5.0
Keywords: pandoc update Cc: jgm@…, boeyms@…
Port:

Description

Modified pandoc's Portfile in the following ways:

+ bumped version to 0.43 (pandoc 0.43 is five times faster than 0.42) + updated md5 sum + changed build-target to 'build-all' and destroot.target to 'install-all':

this installs haskell libraries and library documentation, in addition to the executable and user documentation.

+ added haddock as a build dependency (it is needed to build the library

documentation)

Attachments (2)

Portfile.diff (2.2 KB) - added by jgm@… 17 years ago.
Portfile.2.diff (2.5 KB) - added by jgm@… 17 years ago.
New Portfile.diff, not using cd

Download all attachments as: .zip

Change History (12)

comment:1 Changed 17 years ago by jgm@…

Since I've now released 0.44 (which fixes a critical bug in the debian build process), I attach here a new diff from the Portfile that is currently in the repository (for pandoc 0.42). The diff above for 0.43 may be ignored.

comment:2 Changed 17 years ago by jgm@…

I've fixed a minor mistake in the Portfile.diff (the URL for pandoc's home page was incorrect).

comment:3 Changed 17 years ago by boeyms@…

Cc: jgm@… boeyms@… added
Keywords: pandoc update added
Milestone: Port EnhancementsPort Updates
Owner: changed from macports-dev@… to boeyms@…
Summary: Update Portfile - pandoc 0.43Update Portfile - pandoc 0.44

Everything seems fine except that the pandoc executable itself doesn't get installed (while hsmarkdown, html2markdown and markdown2pdf do). Would you be able to fix this?

Changed 17 years ago by jgm@…

Attachment: Portfile.diff added

comment:4 Changed 17 years ago by jgm@…

Turns out there was a problem with the way the Makefile handles DESTDIR. The pandoc executable and library files were getting copied directly to the /opt/local tree, not to the destroot. Also, the library was not getting registered properly; this must be done in the activate phase, using a register.sh script generated in the destroot phase.

I have provided a new Portfile.diff that fixes all these problems.

comment:5 Changed 17 years ago by jgm@…

Postscript: I have used the Portfile for devel/missingh as a model for the destroot and post-activate phases.

comment:6 Changed 17 years ago by boeyms@…

Status: newassigned

Unfortunately this Portfile will now not work with the trunk version of MacPorts, as the ability for Portfiles to call Tcl's cd proc has been removed (it apparently changes the working directory of the entire Tcl interpreter). Unfortunately, I don't know what the normal working directory is when port is invoked. If it's not possible to rewrite the Portfile's custom destroot stage to work independently of the normal working directory, you could package into the tarball a script that does it (by default the Tcl interpreter forks a process that cd's to ${worksrcpath}). You could also use the system proc made available to Portfiles (see portfile(7)), though I don't recall whether this was being frowned upon as well.

Changed 17 years ago by jgm@…

Attachment: Portfile.2.diff added

New Portfile.diff, not using cd

comment:7 Changed 17 years ago by jgm@…

I've uploaded a new version (Portfile.2.diff) that does not use Tcl's cd.

comment:8 Changed 17 years ago by boeyms@…

Resolution: fixed
Status: assignedclosed

Committed in r29630. Thanks again, and sorry for the bother.

comment:9 Changed 16 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:10 Changed 16 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.