Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#14875 closed submission (fixed)

moc

Reported by: eu@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: multimedia player Cc:
Port:

Description

This is a port of Music On Console player, a full featured player with a ncurses interface, supporting playlists, internet streams and a lot of formats.

Attachments (7)

patch-configure.diff (418 bytes) - added by eu@… 17 years ago.
Portfile (1.4 KB) - added by eu@… 17 years ago.
patch-options.diff (641 bytes) - added by eu@… 17 years ago.
patch-autojack.diff (6.9 KB) - added by eu@… 17 years ago.
autojack.diff (16 bytes) - added by eu@… 17 years ago.
options.c.diff (16 bytes) - added by eu@… 17 years ago.
Portfile.2 (1.6 KB) - added by milosh@… 17 years ago.
Modified Portfile (removed dep on ffmpeg and various other things)

Download all attachments as: .zip

Change History (16)

Changed 17 years ago by eu@…

Attachment: patch-configure.diff added

comment:1 Changed 17 years ago by fran.dieguez@…

I was really interesting at this new port. So I test it and works well. Thanks Mr. Vazquez

comment:2 Changed 17 years ago by fran.dieguez@…

Is there any plan to commit this port to the repository official

comment:3 Changed 17 years ago by milosh@…

The maintainers line is not right. There is no mvazquez_at_macports.org. You have to set it so that port info gives a correct mail address. For example

maintainers martinvazquez.net:eu

the "extract.cmd bunzip2" line is unneeded. There should be a blank line between the first and second. All the patchfiles should be named patch-xxxxx.diff

Does it really depend on ffmpeg?

comment:4 in reply to:  3 Changed 17 years ago by eu@…

Replying to milosh@macports.org:

The maintainers line is not right. There is no mvazquez_at_macports.org. You have to set it so that port info gives a correct mail address. For example

maintainers martinvazquez.net:eu

Ok, i'll change it

the "extract.cmd bunzip2" line is unneeded.

yes, i need it, the default cmd is gunzip and it doesn't change if the extension change (at least in my tests when i comment out that line, the extraction fails)

There should be a blank line between the first and second. All the patchfiles should be named patch-xxxxx.diff

Does it really depend on ffmpeg?

it needs ffmpeg to have the codecs of various audio formats

Changed 17 years ago by eu@…

Attachment: Portfile added

Changed 17 years ago by eu@…

Attachment: patch-options.diff added

Changed 17 years ago by eu@…

Attachment: patch-autojack.diff added

Changed 17 years ago by eu@…

Attachment: autojack.diff added

Changed 17 years ago by eu@…

Attachment: options.c.diff added

Changed 17 years ago by milosh@…

Attachment: Portfile.2 added

Modified Portfile (removed dep on ffmpeg and various other things)

comment:5 Changed 17 years ago by milosh@…

Sorry, did not see your changes: For bzip2, the line to use is "use_bzip2 yes" which sets both extract.cmd and extract.suffix.

I tried without ffmpeg as I was not able to build it (svn checkout failed) which worked. However, it linked with libvorbis and libogg that are installed on my machine; they should either be explicitly removed (--without-vorbis or sthg like that) or a dependency added (optionnally as a variant).

I can commit with those changes if it is okay for you.

comment:6 Changed 17 years ago by milosh@…

Resolution: fixed
Status: newclosed

Committed in r35964. Thanks

comment:7 in reply to:  5 Changed 17 years ago by eu@…

Replying to milosh@macports.org:

Sorry, did not see your changes: For bzip2, the line to use is "use_bzip2 yes" which sets both extract.cmd and extract.suffix.

I tried without ffmpeg as I was not able to build it (svn checkout failed) which worked. However, it linked with libvorbis and libogg that are installed on my machine; they should either be explicitly removed (--without-vorbis or sthg like that) or a dependency added (optionnally as a variant).

I can commit with those changes if it is okay for you.

Ok, thanks

comment:8 Changed 16 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:9 Changed 16 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.