luarocks patch

[ryandesign (Ryan Carsten Schmidt)]

Here's a patch to fix some issues with luarocks, I think. (I don't actually use luarocks).

• You have variants openssl and md5 which I think you intend to be conflicting with one another, but they're not marked as such. Same goes for variants wget and curl.
• Your variants include statements to remove dependencies and configure arguments which have never been added in the first place.
• The port declared a dependency on wget by default even though wget is now a variant.
• I think you meant for one of openssl and md5 to always be selected, and one of wget and curl to always be selected, but didn't write the portfile that way. It was possible to install it with no variant selected.
• You had the dependencies declared as library dependencies, but the port installs only text files, no binaries, so it doesn't use any libraries. Rather, these are runtime dependencies.
• Since the port installs no binaries, the universal variant should be disabled. Attempting to use the universal variant results in the error "Unknown flag: --disable-dependency-tracking"

Remaining issues not solved by my patch:

• Your md5 variant configures luarocks to use the md5sum program to check files, but Mac OS X does not include the md5sum program. You can get it by installing the coreutils port, but there it's called gmd5sum, unless coreutils is installed with the with_default_names variant. So either change the md5 variant to use the gmd5sum program and declare a dependency on port:coreutils, or maybe just remove the md5 variant altogether (unless there's a big advantage to using gmd5sum vs. openssl that I'm not aware of).

[andrea.damore@…]

• I couldn't remember the conflicts syntax, I wrote it this way and made a note to fix it later.

• I tought removing an option that is not configured couldn't harm, I tought it simply had no effect.

• The wget dependency was a legacy from previous version, I forgot to remove it when adding the variant.

• The point is that luarocks will choose between one of curl and wget/md5 and openssl or fail. My idea is to let the user explicitly choose them with variants or just leave the system autodetect.

• I didn't checked the kind of executables, therefore the library dependencies.

• Didn't knew about this.

That said I see md5 on my system is /sbin/md5 so I tought it came with darwin, I don't know of advantage of md5 over openssl so to me it is just fine to have openssl by default.

I've commited your patch and I'm marking this ticket as fixed.

[(none)]

Milestone Port Bugs deleted