Patch updating dnsmasq to 2.42

[dgilman (David Gilman)]

Attached are patches against the port for dnsmasq to bump to version 2.42. I've also added a startupitem to the Portfile.

There is no maintainer for this port.

One question though: the package by default installs an example config file. I think it would be appropriate to remind the user to set this up before loading the package into launchd. What would be the best way to do this?

(macports is really cool, i had no idea about this startupitem option until just a bit ago.)

[dgilman (David Gilman)]

diff of the portfile

[dgilman (David Gilman)]

patch for the makefile

[dgilman (David Gilman)]

patch for an include file

[dgilman (David Gilman)]

Cc Me!

[jmroot (Joshua Root)]

See the squid port for an example of how to handle generating a real config file from a sample one only when the former doesn't exist. Also, please remove the trailing whitespace from the long_description (port lint should warn about that).

[davidgilman1+macports@…]

v2 Portfile with post-activate

[davidgilman1+macports@…]

Ok, updated the portfile with the post-activate stuff for the config file. The default configuration for dnsmasq is to read and poll /etc/resolv.conf for nameservers. MacOS X updates this file by itself.

[jmroot (Joshua Root)]

The config.h patch will need to be changed. MacPorts also works on platforms where __APPLE__ is not defined, and files should still be installed into $prefix on them.

In the portfile, you don't need a foreach loop for one file. This will do:

post-activate {
    # Make sure initial conf file is present and setup correctly
    set f dnsmasq.conf
    if {![file exists ${prefix}/etc/${f}]} {
        file copy ${prefix}/etc/${f}.example \
            ${prefix}/etc/${f}
    }
}

I also notice you're installing it as dnsmasq.conf.sample in the makefile patch but referring to dnsmasq.conf.example in the portfile, so one will need to be changed.

[davidgilman1+macports@…]

3rd revision of proposed portfile

[davidgilman1+macports@…]

3rd revision of proposed config.h patch

[simon@…]

Committed in r37899. Thanks for your help,

Simon

[(none)]

Milestone Port Updates deleted