vobcopy lfs not enabled

[tom.duck@…]

vobcopy does not have large file support (lfs) enabled under 10.4 Tiger. Witness what happens when I try to vobcopy to one large file:

--

$ vobcopy -l

[Error] Wrong option.

Vobcopy 1.1.0 - GPL Copyright (c) 2001 - 2007 robos@…

Usage: vobcopy

[-m (mirror)]

[-i /path/to/the/mounted/dvd/]

[-n title-number]

[-t <your name for the dvd>]

[-o /path/to/output-dir/ (can be "stdout" or "-")]

[-f (force output)]

[-V (version)]

[-v (verbose)]

[-v -v (create log-file)]

[-h (this here ;-)]

[-I (infos about title, chapters and angles on the dvd)]

[-1/path/to/second/output/dir/] [-2/.../third/..] [-3/../] [-4 /../]

[-b <skip-size-at-beginning[bkmg]>]

[-e <skip-size-at-end[bkmg]>]

[-O <single_file_name1,single_file_name2, ...>]

[-q (quiet)]

[-w <watchdog-minutes>]

[-F <fast-factor:1..64>]

--

Perusal of the source shows that the option exists, but for some reason it is not compiled in.

[jmroot (Joshua Root)]

Cc maintainer.

[0booo5b02@…]

At first sight it should work:

svn shows that the portfile invokes config with the appropriate option:

Portfile​

So this is probably a problem in config.sh

I'll try to reproduce the problem.

[tom.duck@…]

To access lfs in vobcopy, HAS_LARGEFILE must be set to 1 in vobcopy.h. If you look at the Darwin section, you will notice that it is commented out. I will email the author to see if there is a reason why.

[tom.duck@…]

It appears that HAS_LARGEFILE was commented out between versions 1.0.2 and 1.1.0. There is no indication of why in the ChangeLog, and both the CVS and mailing list for vobcopy appear to be down.

[0booo5b02@…]

I've been having a look and these are my conclusions:

• HAS_LARGEFILE is not defined no matter what options are given to configure (on OS X)
• There is no need for all the O_LARGEFILE juggling in the source. A regular open is sufficient (I tried this experimentally and it worked)
• The code dealing with these issues is a mess

Given all the previous points this is a bug from the upstream program.

What I propose is this:

I will make a patch that FAPP sets HAS_LARGEFILE but all open calls will be made without O_LARGEFILE). This will result in the -l being available but only really working on systems in which large file support doesn't depend on special options on open. On systems where that does happen a run time error will probably occur.

I don't know in what systems this port will be compiled so the previous solution might break on some.

Unless someone objects I'll write this patch to the source-code and attach it here.

This project could really use something like autotools.

[tom.duck@…]

I have been trying to contact the upstream author since June 21 without a response. The author has been blogging, so given that both the CVS and mailing list archive are down I am uncertain about the status of the project.

If there is uncertainty about the behaviour on different systems, perhaps the patch should be set using an 'lfs' variant. That being said, isn't lfs supported on all systems supported by MacPorts (i.e., OS X 10.4 and 10.5)? I am blissfully unaware of issues surrounding lfs, and so can't comment on what side effects might result from using lfs on an unsupported system.

[(none)]

Milestone Port Bugs deleted

[adam@…]

I have spoken to the developer, Robos via email recently. He says that vobcopy shouldn't have any problem with large file support on OS X.

When the port is update to 1.2.0 (see ticket:20391) HAS_LARGEFILE should be enabled.

[tobypeterson]

might be fixed in r54189

[adam@…]

r54189 does indeed fix this.